Use informer for pod get/list instead of talking to API server.

Signed-off-by: Ville Aikas <[email protected]>

Author: vaikas

pkg/reconciler/taskrun/controller.go

@@ -73,6 +73,7 @@ func NewController(opts *pipeline.Options, clock clock.PassiveClock) func(contex
 			cloudEventClient:    cloudeventclient.Get(ctx),
 			metrics:             taskrunmetrics.Get(ctx),
 			entrypointCache:     entrypointCache,
+			podLister:           podInformer.Lister(),
 			pvcHandler:          volumeclaim.NewPVCHandler(kubeclientset, logger),
 			resolutionRequester: resolution.NewCRDRequester(resolutionclient.Get(ctx), resolutionInformer.Lister()),
 		}

pkg/reconciler/taskrun/taskrun.go

@@ -52,6 +52,7 @@ import (
 	corev1 "k8s.io/api/core/v1"
 	k8serrors "k8s.io/apimachinery/pkg/api/errors"
 	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
+	"k8s.io/apimachinery/pkg/labels"
 	"k8s.io/apimachinery/pkg/util/clock"
 	"k8s.io/client-go/kubernetes"
 	corev1Listers "k8s.io/client-go/listers/core/v1"
@@ -75,6 +76,7 @@ type Reconciler struct {
 	taskRunLister       listers.TaskRunLister
 	resourceLister      resourcelisters.PipelineResourceLister
 	limitrangeLister    corev1Listers.LimitRangeLister
+	podLister           corev1Listers.PodLister
 	cloudEventClient    cloudevent.CEClient
 	entrypointCache     podconvert.EntrypointCache
 	metrics             *taskrunmetrics.Recorder
@@ -424,7 +426,7 @@ func (c *Reconciler) reconcile(ctx context.Context, tr *v1beta1.TaskRun, rtr *re
 	var err error
 
 	if tr.Status.PodName != "" {
-		pod, err = c.KubeClientSet.CoreV1().Pods(tr.Namespace).Get(ctx, tr.Status.PodName, metav1.GetOptions{})
+		pod, err = c.podLister.Pods(tr.Namespace).Get(tr.Status.PodName)
 		if k8serrors.IsNotFound(err) {
 			// Keep going, this will result in the Pod being created below.
 		} else if err != nil {
@@ -438,18 +440,17 @@ func (c *Reconciler) reconcile(ctx context.Context, tr *v1beta1.TaskRun, rtr *re
 		// List pods that have a label with this TaskRun name.  Do not include other labels from the
 		// TaskRun in this selector.  The user could change them during the lifetime of the TaskRun so the
 		// current labels may not be set on a previously created Pod.
-		labelSelector := fmt.Sprintf("%s=%s", pipeline.TaskRunLabelKey, tr.Name)
-		pos, err := c.KubeClientSet.CoreV1().Pods(tr.Namespace).List(ctx, metav1.ListOptions{
-			LabelSelector: labelSelector,
-		})
+		labelSelector := labels.Set{pipeline.TaskRunLabelKey: tr.Name}
+		pos, err := c.podLister.Pods(tr.Namespace).List(labelSelector.AsSelector())
+
 		if err != nil {
 			logger.Errorf("Error listing pods: %v", err)
 			return err
 		}
-		for index := range pos.Items {
-			po := pos.Items[index]
-			if metav1.IsControlledBy(&po, tr) && !podconvert.DidTaskRunFail(&po) {
-				pod = &po
+		for index := range pos {
+			po := pos[index]
+			if metav1.IsControlledBy(po, tr) && !podconvert.DidTaskRunFail(po) {
+				pod = po
 			}
 		}
 	}