Skip to content

Commit 4d0bc61

Browse files
committed
Apply rubocop performance corrections
1 parent ac64f62 commit 4d0bc61

File tree

3 files changed

+3
-4
lines changed

3 files changed

+3
-4
lines changed

lib/gemdiff/bundle_inspector.rb

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,7 @@ def list
88
@list ||=
99
outdated
1010
.split("\n")
11-
.map { |line| new_outdated_gem(line) }
12-
.compact
11+
.filter_map { |line| new_outdated_gem(line) }
1312
end
1413

1514
def outdated

lib/gemdiff/outdated_gem.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -105,7 +105,7 @@ def find_name(name)
105105

106106
def clean_url(url)
107107
uri = URI.parse(url)
108-
uri.path.gsub! %r{/+}, "/"
108+
uri.path.squeeze!("/")
109109
uri.to_s
110110
end
111111

lib/gemdiff/repo_finder.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -115,7 +115,7 @@ def gemspec_homepage(gem_name)
115115
yaml = gemspec(gem_name)
116116
return if yaml.to_s.empty?
117117
spec = YAML.safe_load(yaml, permitted_classes: PERMITTED_GEMSPEC_CLASSES)
118-
return clean_url(spec.homepage) if spec.homepage =~ GITHUB_REPO_REGEX
118+
return clean_url(spec.homepage) if GITHUB_REPO_REGEX.match?(spec.homepage)
119119
match = spec.description.to_s.match(GITHUB_REPO_REGEX)
120120
match && clean_url(match[0])
121121
end

0 commit comments

Comments
 (0)