Merge pull request #90 from djmitche/catch-oneshot-bug

Fail when oneShot doesn't get the right arguments

Author: djmitche

src/base.js

@@ -1,4 +1,5 @@
 const _ = require('lodash');
+const assert = require('assert');
 const debug = require('debug')('taskcluster-lib-monitor');
 
 /**
@@ -169,6 +170,9 @@ class BaseMonitor {
 
     try {
       try {
+        assert.equal(typeof name, 'string');
+        assert.equal(typeof fn, 'function');
+
         await this.timer(`${name}.duration`, fn);
         this.count(`${name}.done`);
       } catch (err) {

src/mockmonitor.js

@@ -64,6 +64,9 @@ class MockMonitor extends BaseMonitor {
    * Override oneShot to helpfully not call process.exit
    */
   async oneShot(name, fn) {
+    assert.equal(typeof name, 'string');
+    assert.equal(typeof fn, 'function');
+
     await fn();
   }
 }

test/base_test.js

@@ -117,5 +117,11 @@ suite('BaseMonitor', function() {
       assert.equal(monitor.counts.length, 0);
       assert(monitor.errors[0].toString().match(/uhoh/), monitor.errors[0]);
     });
+
+    test('missing name', async function() {
+      await monitor.oneShot(async () => { throw new Error('uhoh'); });
+      assert.equal(exitStatus, 1);
+      assert(monitor.errors[0].toString().match(/Assertion/), monitor.errors[0]);
+    });
   });
 });

test/mockmonitor_test.js

@@ -155,7 +155,7 @@ suite('MockMonitor', () => {
   });
 
   test('monitor.oneShot', async () => {
-    monitor.oneShot(() => {});
+    await monitor.oneShot('test', () => {});
     // just expect this not to call process.exit!
   });
 });