core: fix uncle creation in TestFastVsFullChains (ethereum#25476)

int88 · fjl · jagdeep sidhu · commit 1e66593eb63c · 2022-08-09T11:37:56.000-07:00
Co-authored-by: Felix Lange &lt;fjl@twurst.com&gt;
diff --git a/core/blockchain_test.go b/core/blockchain_test.go
@@ -759,9 +759,9 @@ func TestFastVsFullChains(t *testing.T) {
 				block.AddTx(tx)
 			}
 		}
-		// If the block number is a multiple of 5, add a few bonus uncles to the block
-		if i%5 == 5 {
-			block.AddUncle(&types.Header{ParentHash: block.PrevBlock(i - 1).Hash(), Number: big.NewInt(int64(i - 1))})
+		// If the block number is a multiple of 5, add an uncle to the block
+		if i%5 == 4 {
+			block.AddUncle(&types.Header{ParentHash: block.PrevBlock(i - 2).Hash(), Number: big.NewInt(int64(i))})
 		}
 	})
 	// Import the chain as an archive node for the comparison baseline

Original file line number	Diff line number	Diff line change
`@@ -759,9 +759,9 @@ func TestFastVsFullChains(t *testing.T) {`
`759`	`759`	`block.AddTx(tx)`
`760`	`760`	`}`
`761`	`761`	`}`
`762`		`- // If the block number is a multiple of 5, add a few bonus uncles to the block`
`763`		`- if i%5 == 5 {`
`764`		`- block.AddUncle(&types.Header{ParentHash: block.PrevBlock(i - 1).Hash(), Number: big.NewInt(int64(i - 1))})`
	`762`	`+ // If the block number is a multiple of 5, add an uncle to the block`
	`763`	`+ if i%5 == 4 {`
	`764`	`+ block.AddUncle(&types.Header{ParentHash: block.PrevBlock(i - 2).Hash(), Number: big.NewInt(int64(i))})`
`765`	`765`	`}`
`766`	`766`	`})`
`767`	`767`	`// Import the chain as an archive node for the comparison baseline`