From e80673060dd8769f5d9eabb4f18ca84f07c3a30c Mon Sep 17 00:00:00 2001 From: aruljenithberkmans Date: Thu, 28 Aug 2025 13:59:18 +0530 Subject: [PATCH 1/2] Remove the ymin value from AreaSegment setdata method --- maui/src/Charts/Segment/AreaSegment.cs | 2 -- maui/src/Charts/Segment/PolarAreaSegment.cs | 2 -- maui/src/Charts/Segment/SplineAreaSegment.cs | 2 -- maui/src/Charts/Segment/SplineRangeAreaSegment.cs | 2 -- maui/src/Charts/Segment/StackingAreaSegment.cs | 2 -- 5 files changed, 10 deletions(-) diff --git a/maui/src/Charts/Segment/AreaSegment.cs b/maui/src/Charts/Segment/AreaSegment.cs index 366f7a22..4935cd3e 100644 --- a/maui/src/Charts/Segment/AreaSegment.cs +++ b/maui/src/Charts/Segment/AreaSegment.cs @@ -184,8 +184,6 @@ internal override void SetData(IList xValues, IList yValues) var yMin = YValues.Min(); yMin = double.IsNaN(yMin) ? YValues.Length > 0 ? YValues.Where(e => !double.IsNaN(e)).DefaultIfEmpty().Min() : 0 : yMin; - var start = series.ActualYAxis.VisibleRange.Start; - yMin = yMin == 0 ? (double.IsNaN(start) ? yMin : start) : yMin; Empty = double.IsNaN(yMin); diff --git a/maui/src/Charts/Segment/PolarAreaSegment.cs b/maui/src/Charts/Segment/PolarAreaSegment.cs index 06ad5205..e5d0c130 100644 --- a/maui/src/Charts/Segment/PolarAreaSegment.cs +++ b/maui/src/Charts/Segment/PolarAreaSegment.cs @@ -75,8 +75,6 @@ internal override void SetData(IList xDatas, IList yDatas) yDatas.CopyTo(_yValues, 0); var yMin = _yValues.Min(); yMin = double.IsNaN(yMin) ? _yValues.Length > 0 ? _yValues.Where(e => !double.IsNaN(e)).DefaultIfEmpty().Min() : 0 : yMin; - var start = series.ActualYAxis.VisibleRange.Start; - yMin = yMin == 0 ? (double.IsNaN(start) ? yMin : start) : yMin; series.XRange += new DoubleRange(_xValues.Min(), _xValues.Max()); series.YRange += new DoubleRange(yMin, _yValues.Max()); } diff --git a/maui/src/Charts/Segment/SplineAreaSegment.cs b/maui/src/Charts/Segment/SplineAreaSegment.cs index c802ec38..ec2bde86 100644 --- a/maui/src/Charts/Segment/SplineAreaSegment.cs +++ b/maui/src/Charts/Segment/SplineAreaSegment.cs @@ -137,8 +137,6 @@ void UpdateRange() { _minY = YVal.Min(); _minY = double.IsNaN(_minY) ? YVal.Length > 0 ? YVal.Where(e => !double.IsNaN(e)).DefaultIfEmpty().Min() : 0 : _minY; - var start = series.ActualYAxis.VisibleRange.Start; - _minY = _minY == 0 ? (double.IsNaN(start) ? _minY : start) : _minY; _maxY = YVal.Max(); double startControlMin = ControlStartY.Min(); diff --git a/maui/src/Charts/Segment/SplineRangeAreaSegment.cs b/maui/src/Charts/Segment/SplineRangeAreaSegment.cs index ba212924..f8a6063a 100644 --- a/maui/src/Charts/Segment/SplineRangeAreaSegment.cs +++ b/maui/src/Charts/Segment/SplineRangeAreaSegment.cs @@ -266,8 +266,6 @@ void UpdateRange() { _min = HighVal.Min(); _min = double.IsNaN(_min) ? HighVal.Length > 0 ? HighVal.Where(e => !double.IsNaN(e)).DefaultIfEmpty().Min() : 0 : _min; - var start = series.ActualYAxis.VisibleRange.Start; - _min = _min == 0 ? (double.IsNaN(start) ? _min : start) : _min; _max = HighVal.Max(); if (HighControlStartY != null && HighControlEndY != null) diff --git a/maui/src/Charts/Segment/StackingAreaSegment.cs b/maui/src/Charts/Segment/StackingAreaSegment.cs index f4a89ff8..6efc0866 100644 --- a/maui/src/Charts/Segment/StackingAreaSegment.cs +++ b/maui/src/Charts/Segment/StackingAreaSegment.cs @@ -44,8 +44,6 @@ internal void SetData(IList xValues, IList yEnds, IList yStarts) var yMin = TopValues.Min(); yMin = double.IsNaN(yMin) ? TopValues.Length > 0 ? TopValues.Where(e => !double.IsNaN(e)).DefaultIfEmpty().Min() : 0 : yMin; - var start = series.ActualYAxis.VisibleRange.Start; - yMin = yMin == 0 ? (double.IsNaN(start) ? yMin : start) : yMin; Series.XRange += new DoubleRange(XValues.Min(), XValues.Max()); Series.YRange += new DoubleRange(yMin, TopValues.Max()); From 985f4f04a4345a1082f7e63774ae4545f89cfed7 Mon Sep 17 00:00:00 2001 From: aruljenithberkmans Date: Thu, 11 Sep 2025 12:04:38 +0530 Subject: [PATCH 2/2] Update missed Unit test cases --- .../Chart/Features/ChartFeatureAxisUnitTest.cs | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/maui/tests/Syncfusion.Maui.Toolkit.UnitTest/Chart/Features/ChartFeatureAxisUnitTest.cs b/maui/tests/Syncfusion.Maui.Toolkit.UnitTest/Chart/Features/ChartFeatureAxisUnitTest.cs index 527f8632..a95537ed 100644 --- a/maui/tests/Syncfusion.Maui.Toolkit.UnitTest/Chart/Features/ChartFeatureAxisUnitTest.cs +++ b/maui/tests/Syncfusion.Maui.Toolkit.UnitTest/Chart/Features/ChartFeatureAxisUnitTest.cs @@ -1534,7 +1534,7 @@ public void AddSmallTicksPoint_ShouldAddCorrectNumberOfSmallTicks() } [Theory] - [InlineData(0, 100, 1)] + [InlineData(0, 100, 20)] [InlineData(0, 365, 2)] public void CalculateNiceInterval_ShouldReturnCorrectInterval(double start, double end, double expectedInterval) { @@ -1604,7 +1604,7 @@ public void OnMinMaxChanged_ShouldUpdateActualRangeWithMinMaxValues_WhenMinMaxAr [InlineData(DateTimeIntervalType.Years, 0.1)] [InlineData(DateTimeIntervalType.Months, 1)] [InlineData(DateTimeIntervalType.Days, 50)] - [InlineData(DateTimeIntervalType.Hours, 1000)] + [InlineData(DateTimeIntervalType.Hours, 500)] [InlineData(DateTimeIntervalType.Minutes, 50000)] [InlineData(DateTimeIntervalType.Seconds, 2000000)] public void CalculateDateTimeIntervalType_ShouldReturnCorrectInterval_ForGivenIntervalType(DateTimeIntervalType intervalType, double expectedInterval) @@ -2062,8 +2062,8 @@ public void CalculateActualRange_ReturnsExpectedRange(double defaultMin, double } [Theory] - [InlineData(double.NaN, 10)] - [InlineData(0, 10)] + [InlineData(double.NaN, 5)] + [InlineData(0, 5)] [InlineData(5, 5)] public void CalculateActualInterval_ReturnsExpectedInterval(double axisInterval, double expected) { @@ -2081,7 +2081,7 @@ public void CalculateActualInterval_ReturnsExpectedInterval(double axisInterval, } [Theory] - [InlineData(1, 10, 100, 10)] + [InlineData(1, 10, 100, 5)] [InlineData(1, 1000, 100, 1000)] [InlineData(1, 1000, 10, 1000)] public void CalculateNiceInterval_ReturnsExpectedInterval(double rangeStart, double rangeEnd, int availableWidth, double expected)