Skip to content

Improve the touch interaction in Maui toolkit Navigation drawer. #126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 13, 2025
Merged

Improve the touch interaction in Maui toolkit Navigation drawer. #126

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 14 additions & 9 deletions maui/src/NavigationDrawer/SfNavigationDrawer.Android.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ internal override bool OnInterceptTouchEvent(MotionEvent? ev)
switch (ev.Action)
{
case MotionEventActions.Down:
return HandleActionDown(currentTouchPoint);
return HandleActionDown(ev, currentTouchPoint);

case MotionEventActions.Up:
_initialPoint = new Point(0, 0);
Expand All @@ -95,18 +95,23 @@ internal override bool OnInterceptTouchEvent(MotionEvent? ev)

#region Private Methods

private bool HandleActionDown(Point currentTouchPoint)
private bool HandleActionDown(MotionEvent? ev, Point currentTouchPoint)
{
_downX = currentTouchPoint.X;
_downY = currentTouchPoint.Y;
_initialPoint = currentTouchPoint;

if (DrawerSettings.Position == Position.Left || DrawerSettings.Position == Position.Right)
if (ev != null)
{
return HandleHorizontalActionDown(currentTouchPoint);
_downX = ev.GetX();
_downY = ev.GetY();
_initialPoint = currentTouchPoint;

if (DrawerSettings.Position == Position.Left || DrawerSettings.Position == Position.Right)
{
return HandleHorizontalActionDown(currentTouchPoint);
}

return HandleVerticalActionDown(currentTouchPoint);
}

return HandleVerticalActionDown(currentTouchPoint);
return false;
}

private bool HandleHorizontalActionDown(Point currentTouchPoint)
Expand Down