Merge pull request #37 from The-Debarghya/fix-minors

fix formatting checks with minor argument changes in dockerfiles

Author: tanmoysrt

.github/workflows/go-lint-build.yml

@@ -12,10 +12,54 @@ permissions:
   pull-requests: read
 
 jobs:
+  gofmt-unix:
+    strategy:
+      matrix:
+        go: ["1.20"]
+        os: [macos-latest, ubuntu-latest]
+    name: gofmt
+    runs-on: ${{ matrix.os }}
+    steps:
+      - uses: actions/checkout@v3
+      - uses: actions/setup-go@v4
+        with:
+          go-version: ${{ matrix.go }}
+          cache: true
+      - name: Run format checks
+        run: |
+          if [ $(gofmt -d -l -e . | wc -l) -eq 0 ]; then
+              printf 'Format Checks Have Passed!!!'
+          else
+              printf 'Format Checks Have Failed!\nPlease use gofmt in your system to format your code.'
+              gofmt -l -e -d . 
+              exit 1 
+          fi
+  gofmt-windows:
+    strategy:
+      matrix:
+        go: ["1.20"]
+        os: [windows-latest]
+    name: gofmt
+    runs-on: ${{ matrix.os }}
+    steps:
+      - uses: actions/checkout@v3
+      - uses: actions/setup-go@v4
+        with:
+          go-version: ${{ matrix.go }}
+          cache: true
+      - name: Run format checks
+        run: |
+          if ((gofmt -d -l -e . | Measure-Object -Line).Lines -eq 0) {
+            Write-Host 'Format Checks Have Passed!!!'
+          } else {
+            Write-Host 'Format Checks Have Failed!'
+            gofmt -l -e -d .
+            exit 1
+          }
   golangci:
     strategy:
       matrix:
-        go: ['1.20']
+        go: ["1.20"]
         os: [macos-latest, windows-latest, ubuntu-latest]
     name: lint
     runs-on: ${{ matrix.os }}
@@ -44,6 +88,3 @@ jobs:
 
       - name: Run staticcheck
         run: staticcheck ./...
-      
-      - name: Run format checks
-        run: gofmt -l -d -e .

docker_config_generator/helper.go

@@ -145,4 +145,4 @@ func SanitizeFileName(fileName string) string {
 	// You can add more sanitization rules as needed
 
 	return fileName
-}
+}

docker_config_generator/templates/fastapi-pip.Dockerfile

@@ -26,7 +26,7 @@ ENV PYTHONDONTWRITEBYTECODE=1
 ENV PYTHONUNBUFFERED=1
 
 # -- args
-ARG PORT=80
+ARG PORT="80"
 ARG START_COMMAND="python -m uvicorn main:app --host=0.0.0.0"
 ARG PEX_WRAPPER="pex_wrapper"
 

docker_config_generator/templates/fastapi-poetry.Dockerfile

@@ -20,7 +20,7 @@ RUN python3 -m venv $POETRY_VENV \
 # Create a new stage from the base python image
 FROM python-base as final
 
-ARG PORT=80
+ARG PORT="80"
 ARG START_COMMAND="poetry run python -m uvicorn main:app --host=0.0.0.0"
 # Copy Poetry to app image
 COPY --from=poetry-base ${POETRY_VENV} ${POETRY_VENV}

docker_config_generator/templates/flask-pip.Dockerfile

@@ -25,7 +25,7 @@ ENV PYTHONDONTWRITEBYTECODE=1
 ENV PYTHONUNBUFFERED=1
 
 # -- args
-ARG PORT=80
+ARG PORT="80"
 ARG START_COMMAND="python -m flask --app main run --host=0.0.0.0"
 ARG PEX_WRAPPER="pex_wrapper"
 

docker_config_generator/templates/flask-poetry.Dockerfile

@@ -20,7 +20,7 @@ RUN python3 -m venv $POETRY_VENV \
 # Create a new stage from the base python image
 FROM python-base as final
 
-ARG PORT=80
+ARG PORT="80"
 ARG START_COMMAND="poetry run flask --app main run --host=0.0.0.0"
 # Copy Poetry to app image
 COPY --from=poetry-base ${POETRY_VENV} ${POETRY_VENV}

docker_config_generator/templates/nextjs.Dockerfile

@@ -32,7 +32,7 @@ RUN ${BUILD_COMMAND} && npm prune --production
 FROM node:18.11-slim AS runner
 
 # Build args
-ARG PORT=80
+ARG PORT="80"
 
 WORKDIR /app
 ENV NODE_ENV production

docker_config_generator/templates/nodejs.Dockerfile

@@ -13,7 +13,7 @@ RUN \
 # Production image, copy all the files and run
 FROM node:lts-slim AS runner
 
-ARG PORT=80
+ARG PORT="80"
 ARG START_COMMAND="npm run start"
 
 WORKDIR /app

docker_config_generator/templates/streamlit-pip.Dockerfile

@@ -26,7 +26,7 @@ ENV PYTHONDONTWRITEBYTECODE=1
 ENV PYTHONUNBUFFERED=1
 
 # -- args
-ARG PORT=80
+ARG PORT="80"
 ARG START_COMMAND="streamlit run main.py --server.port $PORT"
 ARG PEX_WRAPPER="pex_wrapper"
 

docker_config_generator/templates/streamlit-poetry.Dockerfile

@@ -20,7 +20,7 @@ RUN poetry install --without dev --no-root && rm -rf $POETRY_CACHE_DIR
 # The runtime image, used to just run the code provided its virtual environment
 FROM python:3.11-slim-buster as runner
 
-ARG PORT=80
+ARG PORT="80"
 ARG START_COMMAND="poetry run streamlit run main.py --server.port ${PORT}"
 ENV VIRTUAL_ENV=/app/.venv \
 PATH="/app/.venv/bin:$PATH"