Skip to content

Commit 6f15fc6

Browse files
authored
fix: ingress and redirect rule haproxy operations bug resolved (#169)
1 parent b2aa610 commit 6f15fc6

File tree

3 files changed

+18
-10
lines changed

3 files changed

+18
-10
lines changed

swiftwave_service/core/ingress_rule.operations.go

Lines changed: 9 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -65,14 +65,18 @@ func (ingressRule *IngressRule) Update(ctx context.Context, db gorm.DB) error {
6565
func (ingressRule *IngressRule) Delete(ctx context.Context, db gorm.DB, force bool) error {
6666
if !force {
6767
// verify if ingress rule is not deleting
68-
isDeleting := ingressRule.isDeleting()
69-
if isDeleting {
68+
if ingressRule.isDeleting() {
7069
return errors.New("ingress rule is deleting")
7170
}
71+
// update status to deleting
72+
tx := db.Model(&ingressRule).Update("status", IngressRuleStatusDeleting)
73+
return tx.Error
74+
} else {
75+
// Delete ingress rule
76+
tx := db.Delete(&ingressRule)
77+
return tx.Error
7278
}
73-
// update status to deleting
74-
tx := db.Model(&ingressRule).Update("status", IngressRuleStatusDeleting)
75-
return tx.Error
79+
7680
}
7781

7882
func (ingressRule *IngressRule) isDeleting() bool {

swiftwave_service/core/redirect_rule.oprations.go

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -61,10 +61,14 @@ func (redirectRule *RedirectRule) Delete(ctx context.Context, db gorm.DB, force
6161
if redirectRule.isDeleting() {
6262
return errors.New("redirect rule is already deleting")
6363
}
64+
// update record
65+
tx := db.Model(&redirectRule).Update("status", RedirectRuleStatusDeleting)
66+
return tx.Error
67+
} else {
68+
// delete record
69+
tx := db.Delete(&redirectRule)
70+
return tx.Error
6471
}
65-
// update record
66-
tx := db.Model(&redirectRule).Update("status", RedirectRuleStatusDeleting)
67-
return tx.Error
6872
}
6973

7074
func (redirectRule *RedirectRule) isDeleting() bool {

swiftwave_service/graphql/redirect_rule.resolvers.go

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)