Skip to content

Commit 2811beb

Browse files
authored
fix: on delete git credential and image credential remove relation to all deployments (#193)
1 parent f92b9ea commit 2811beb

File tree

4 files changed

+24
-2
lines changed

4 files changed

+24
-2
lines changed

swiftwave_service/core/git_credential.operations.go

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,11 @@ func (gitCredential *GitCredential) Update(ctx context.Context, db gorm.DB) erro
3333
}
3434

3535
func (gitCredential *GitCredential) Delete(ctx context.Context, db gorm.DB) error {
36+
// set gitCredentialID null for all deployment using this gitCredential
37+
err := db.Model(&Deployment{}).Where("git_credential_id = ?", gitCredential.ID).Update("git_credential_id", nil).Error
38+
if err != nil {
39+
return err
40+
}
3641
tx := db.Delete(&gitCredential)
3742
return tx.Error
3843
}

swiftwave_service/core/image_registry_credential.operations.go

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,11 @@ func (imageRegistryCredential *ImageRegistryCredential) Update(ctx context.Conte
3333
}
3434

3535
func (imageRegistryCredential *ImageRegistryCredential) Delete(ctx context.Context, db gorm.DB) error {
36+
// set imageRegistryCredentialID null for all deployment using this imageRegistryCredential
37+
err := db.Model(&Deployment{}).Where("image_registry_credential_id = ?", imageRegistryCredential.ID).Update("image_registry_credential_id", nil).Error
38+
if err != nil {
39+
return err
40+
}
3641
tx := db.Delete(&imageRegistryCredential)
3742
return tx.Error
3843
}

swiftwave_service/graphql/git_credential.resolvers.go

Lines changed: 7 additions & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

swiftwave_service/graphql/image_registry_credential.resolvers.go

Lines changed: 7 additions & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)