Merge pull request #18 from dcci/lestrythemonorepo

dcci · web-flow · commit f23a77f6e3b6 · 2019-10-24T10:13:55.000-07:00
[SwiftLanguageRuntime] Get rid of some legacy.
diff --git a/lldb/source/Target/SwiftLanguageRuntime.cpp b/lldb/source/Target/SwiftLanguageRuntime.cpp
@@ -1983,13 +1983,6 @@ Value::ValueType SwiftLanguageRuntime::GetValueType(
                                       eTypeInstanceIsPointer))
         return Value::eValueTypeLoadAddress;
     }
-
-    if (static_type_flags.AllSet(eTypeIsSwift | eTypeIsPointer) &&
-        static_type_flags.AllClear(eTypeIsGenericTypeParam)) {
-      // FIXME: This branch is not covered by any testcases in the test suite.
-      if (is_indirect_enum_case || static_type_flags.AllClear(eTypeIsBuiltIn))
-        return Value::eValueTypeLoadAddress;
-    }
   }
 
   // Enabling this makes the inout_variables test hang.

Original file line number	Diff line number	Diff line change
`@@ -1983,13 +1983,6 @@ Value::ValueType SwiftLanguageRuntime::GetValueType(`
`1983`	`1983`	`eTypeInstanceIsPointer))`
`1984`	`1984`	`return Value::eValueTypeLoadAddress;`
`1985`	`1985`	`}`
`1986`		`-`
`1987`		`- if (static_type_flags.AllSet(eTypeIsSwift \| eTypeIsPointer) &&`
`1988`		`- static_type_flags.AllClear(eTypeIsGenericTypeParam)) {`
`1989`		`- // FIXME: This branch is not covered by any testcases in the test suite.`
`1990`		`- if (is_indirect_enum_case \|\| static_type_flags.AllClear(eTypeIsBuiltIn))`
`1991`		`- return Value::eValueTypeLoadAddress;`
`1992`		`- }`
`1993`	`1986`	`}`
`1994`	`1987`
`1995`	`1988`	`// Enabling this makes the inout_variables test hang.`