refactor(visit): Use separate crate for hooks (#11243)

Author: kdy1

.tokeignore

@@ -0,0 +1 @@
+**/generated.rs

Cargo.lock

@@ -0,0 +1,22 @@
+[package]
+authors       = ["강동윤 <[email protected]>"]
+description   = "Composable hooks for swc ecmascript visitors"
+documentation = "https://rustdoc.swc.rs/swc_ecma_hooks/"
+edition       = { workspace = true }
+license       = { workspace = true }
+name          = "swc_ecma_hooks"
+repository    = { workspace = true }
+version       = "0.1.0"
+
+[package.metadata.docs.rs]
+all-features = true
+rustdoc-args = ["--cfg", "docsrs"]
+
+[lib]
+bench = false
+
+[dependencies]
+swc_atoms      = { version = "9.0.0", path = "../swc_atoms" }
+swc_common     = { version = "17.0.0", path = "../swc_common" }
+swc_ecma_ast   = { version = "18.0.0", path = "../swc_ecma_ast" }
+swc_ecma_visit = { version = "18.0.0", path = "../swc_ecma_visit" }

crates/swc_ecma_hooks/Cargo.toml

@@ -0,0 +1,14 @@
+//! Composable hooks for SWC ECMAScript visitors.
+//!
+//! This crate provides a hook-based API for composing AST visitors,
+//! allowing you to build complex visitors by combining simple hooks.
+
+#![cfg_attr(docsrs, feature(doc_cfg))]
+#![deny(clippy::all)]
+#![allow(clippy::ptr_arg)]
+
+pub use swc_ecma_ast;
+pub use swc_ecma_visit;
+
+pub use crate::generated::*;
+mod generated;

crates/swc_ecma_hooks/src/generated.rs

@@ -34,3 +34,6 @@ swc_atoms    = { version = "9.0.0", path = "../swc_atoms" }
 swc_common   = { version = "17.0.0", path = "../swc_common" }
 swc_ecma_ast = { version = "18.0.0", path = "../swc_ecma_ast" }
 swc_visit    = { version = "2.0.1", path = "../swc_visit" }
+
+[dev-dependencies]
+swc_ecma_hooks = { version = "0.1.0", path = "../swc_ecma_hooks" }

crates/swc_ecma_hooks/src/lib.rs

@@ -1,7 +1,8 @@
 use swc_atoms::atom;
 use swc_common::{Span, DUMMY_SP};
 use swc_ecma_ast::*;
-use swc_ecma_visit::{CompositeHook, VisitMutHook, VisitMutWith, VisitMutWithHook};
+use swc_ecma_hooks::{CompositeHook, VisitMutHook, VisitMutWithHook};
+use swc_ecma_visit::VisitMutWith;
 
 #[derive(Debug, Default)]
 struct Hook {

crates/swc_ecma_regexp_visit/src/generated.rs

@@ -96,15 +96,6 @@ pub fn generate(crate_name_str: &str, node_types: &[&Item], excluded_types: &[St
         }
     }
 
-    // Generate VisitMutHook trait and related types
-    output
-        .items
-        .extend(generate_visit_mut_hook_trait(&all_types));
-    output.items.extend(generate_composite_hook(&all_types));
-    output
-        .items
-        .extend(generate_visit_mut_with_hook(&all_types));
-
     output.items.push(parse_quote!(
         #[cfg(any(docsrs, feature = "path"))]
         pub type AstKindPath = swc_visit::AstKindPath<AstParentKind>;
@@ -118,6 +109,59 @@ pub fn generate(crate_name_str: &str, node_types: &[&Item], excluded_types: &[St
     output
 }
 
+#[cfg(test)]
+pub fn generate_hooks(
+    _crate_name_str: &str,
+    node_types: &[&Item],
+    excluded_types: &[String],
+) -> File {
+    let mut output = File {
+        shebang: None,
+        attrs: Vec::new(),
+        items: Vec::new(),
+    };
+    let mut all_types = all_field_types(node_types).into_iter().collect::<Vec<_>>();
+
+    if !excluded_types.is_empty() {
+        all_types.retain(|ty| {
+            !excluded_types
+                .iter()
+                .any(|type_name| ty.contains_type(type_name))
+        });
+    }
+
+    all_types.sort_by_cached_key(|v| v.method_name());
+
+    output.attrs.push(parse_quote!(
+        //! This file is generated by `tools/generate-code`. DO NOT MODIFY.
+    ));
+    output.attrs.push(parse_quote!(
+        #![allow(unused_variables)]
+    ));
+    output.attrs.push(parse_quote!(
+        #![allow(clippy::all)]
+    ));
+
+    output.items.push(parse_quote!(
+        use swc_ecma_ast::*;
+    ));
+
+    output.items.push(parse_quote!(
+        use swc_ecma_visit::*;
+    ));
+
+    // Generate VisitMutHook trait and related types
+    output
+        .items
+        .extend(generate_visit_mut_hook_trait(&all_types));
+    output.items.extend(generate_composite_hook(&all_types));
+    output
+        .items
+        .extend(generate_visit_mut_with_hook(&all_types));
+
+    output
+}
+
 #[derive(Debug, Clone, PartialEq, Eq, PartialOrd, Ord, Hash)]
 enum FieldType {
     Normal(String),
@@ -1721,6 +1765,7 @@ fn define_fields(crate_name: &Ident, node_types: &[&Item]) -> Vec<Item> {
 
 /// Generates the VisitMutHook trait with enter_xxx and exit_xxx methods for
 /// each AST type
+#[cfg(test)]
 fn generate_visit_mut_hook_trait(all_types: &[FieldType]) -> Vec<Item> {
     let mut items = Vec::<Item>::new();
     let mut trait_methods = Vec::<TraitItem>::new();
@@ -1777,6 +1822,7 @@ fn generate_visit_mut_hook_trait(all_types: &[FieldType]) -> Vec<Item> {
 }
 
 /// Generates the CompositeHook<A, B> struct and its VisitMutHook implementation
+#[cfg(test)]
 fn generate_composite_hook(all_types: &[FieldType]) -> Vec<Item> {
     let mut items = Vec::<Item>::new();
     let mut impl_methods = Vec::<TraitItem>::new();
@@ -1842,6 +1888,7 @@ fn generate_composite_hook(all_types: &[FieldType]) -> Vec<Item> {
 }
 
 /// Generates the VisitMutWithHook<H> adapter that implements VisitMut
+#[cfg(test)]
 fn generate_visit_mut_with_hook(all_types: &[FieldType]) -> Vec<Item> {
     let mut items = Vec::<Item>::new();
     let mut impl_methods = Vec::<TraitItem>::new();