Merge pull request #270 from supertokens/fix/cookie-expiry-format

fix: Django cookie expiry time format

Author: rishabhpoddar

CHANGELOG.md

@@ -7,6 +7,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## unreleased
 
+-  Fix django cookie expiry time format to make it consistent with other frameworks
+
 ## [0.11.11] - 2022-12-26
 
 -   Updates dashboard version

supertokens_python/framework/django/django_response.py

@@ -51,7 +51,7 @@ def set_cookie(
             key=key,
             value=value,
             expires=datetime.fromtimestamp(ceil(expires / 1000)).strftime(
-                "%A, %B %d, %Y %H:%M:%S"
+                "%a, %d %b %Y %H:%M:%S GMT"
             ),
             path=path,
             domain=domain,

tests/Django/test_django.py

@@ -16,6 +16,7 @@
 from inspect import isawaitable
 from typing import Any, Dict, Union
 
+from datetime import datetime
 from django.http import HttpRequest, HttpResponse, JsonResponse
 from django.test import RequestFactory, TestCase
 from supertokens_python import InputAppInfo, SupertokensConfig, init
@@ -252,6 +253,13 @@ async def test_login_handle(self):
         assert len(cookies["sIdRefreshToken"]["value"]) > 0
         assert len(cookies["sRefreshToken"]["value"]) > 0
 
+        try:
+            datetime.strptime(
+                cookies["sAccessToken"]["expires"], "%a, %d %b %Y %H:%M:%S GMT"
+            )
+        except ValueError:
+            assert False, "cookies expiry time doesn't have the correct format"
+
         my_middleware = middleware(handle_view)
         request = self.factory.get("/handle", {"user_id": "user_id"})