fix(auth): make AuthClient an Actor #664
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes significant changes to the
AuthClientclass inSources/Auth/AuthClient.swiftto improve concurrency handling and integrate Combine for handling app lifecycle changes.Concurrency improvements:
AuthClientfrom afinal classto anactorto leverage Swift's concurrency model.To keep backward compatibility, had to mark a few properties and methods of
AuthClientasnonisolated, thenonisolatedmark, shall be removed on a next major release.Combine integration:
Because of the change from class to actor, I had to change the way we observe the notification center.
Combineimport conditionally based on availability.observeAppLifecycleChangesto use Combine publishers for handling app lifecycle notifications.These changes improve the concurrency model of
AuthClientand modernize the handling of app lifecycle events using Combine.