Skip to content

guix: remove GUI leftovers #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 1, 2025
Merged

guix: remove GUI leftovers #11

merged 3 commits into from
Sep 1, 2025

Conversation

@fanquake
Copy link
Contributor

@fanquake fanquake commented Sep 1, 2025

No description provided.

@fanquake
guix: remove bison
d0a021c 
This was only needed for the GUI.
@fanquake
guix: remove pkg-config
a02663a 
This was only needed for the GUI.
@fanquake
guix: remove xz
8c53e2b 
This was only needed for the GUI.
@Sjors
Copy link
Collaborator

Sjors commented Sep 1, 2025

Thanks!

x86_64 guix hashes for the platforms that I'm currently shipping releases for (once Windows support works, I'll probably just ship them all):

HOSTS="arm64-apple-darwin x86_64-apple-darwin x86_64-linux-gnu arm-linux-gnueabihf aarch64-linux-gnu" contrib/guix/guix-build
find guix-build-$(git rev-parse --short=12 HEAD)/output/ -type f -print0 | env LC_ALL=C sort -z | xargs -r0 sha256sum
83f42bd9b1a7c725375d5294cb78e725fe66fddd39a77eca55f5a79be4567aae  guix-build-8c53e2ba80e5/output/aarch64-linux-gnu/SHA256SUMS.part
9398163ed4a42346537a68c02703c78f13b6b0a8b0bbadc74eb339aa58be6907  guix-build-8c53e2ba80e5/output/aarch64-linux-gnu/sv2-tp-8c53e2ba80e5-aarch64-linux-gnu-debug.tar.gz
0b5a74f0ab939ebdb31d22f85d15bb7ce8964ce9e12c98e03e66c8e9e8d5eeaa  guix-build-8c53e2ba80e5/output/aarch64-linux-gnu/sv2-tp-8c53e2ba80e5-aarch64-linux-gnu.tar.gz
fe630dd2a806eb99470a80e22f78a30deb6c90143040e83800d017af0d3ad3e9  guix-build-8c53e2ba80e5/output/arm-linux-gnueabihf/SHA256SUMS.part
8cb1a7fda5ef5b062873cb46908c843096c3e1c5b3cce9c3a36baa847eb0881e  guix-build-8c53e2ba80e5/output/arm-linux-gnueabihf/sv2-tp-8c53e2ba80e5-arm-linux-gnueabihf-debug.tar.gz
c2dcf88664ad6084c92bc7120e67fe7fb455031013eb9c905db5bf6c116507a9  guix-build-8c53e2ba80e5/output/arm-linux-gnueabihf/sv2-tp-8c53e2ba80e5-arm-linux-gnueabihf.tar.gz
85423f69bbdbf775140ea508747c2a6b40d31fac9b0497d60f3a94fd81b06cb8  guix-build-8c53e2ba80e5/output/arm64-apple-darwin/SHA256SUMS.part
e34fe5503f5c11f90bc7840eb097080a4cbd639e7eb6e34d4260a268e589f16e  guix-build-8c53e2ba80e5/output/arm64-apple-darwin/sv2-tp-8c53e2ba80e5-arm64-apple-darwin-codesigning.tar.gz
5477c27725baa07b48e44375b6c8f2da743fcec9fe0018b0e63f5bed72da4079  guix-build-8c53e2ba80e5/output/arm64-apple-darwin/sv2-tp-8c53e2ba80e5-arm64-apple-darwin-unsigned.tar.gz
f29831e6177abac9ae57b37ecc4bef808fbb1b4c8412582bb8f164176d11e667  guix-build-8c53e2ba80e5/output/dist-archive/sv2-tp-8c53e2ba80e5.tar.gz
49323a57b9c274192850861e2d62056ecfe368086ca7a791383bebe685d65cd5  guix-build-8c53e2ba80e5/output/x86_64-apple-darwin/SHA256SUMS.part
84fb4b315f88c639c3a95e6f80f50266e9dac54d9e6eb15551bd13c13a0364ef  guix-build-8c53e2ba80e5/output/x86_64-apple-darwin/sv2-tp-8c53e2ba80e5-x86_64-apple-darwin-codesigning.tar.gz
6257b44571623af2b11dd4f370fed052e51bc9f7f1cab469ade399629a818197  guix-build-8c53e2ba80e5/output/x86_64-apple-darwin/sv2-tp-8c53e2ba80e5-x86_64-apple-darwin-unsigned.tar.gz
c495cb4ab2c23143a6fd54eb20cbc78e45267370f042531a6523cef0c64ff69d  guix-build-8c53e2ba80e5/output/x86_64-linux-gnu/SHA256SUMS.part
4f16a001d6c6ccf81de4b11b7dd387c4d5b9f5658cb8d3f5701c8371d70851f3  guix-build-8c53e2ba80e5/output/x86_64-linux-gnu/sv2-tp-8c53e2ba80e5-x86_64-linux-gnu-debug.tar.gz
299f6bafdc979ded9ad7a7f1104e6a0b590652357d8f23a89ba5cce751dc5986  guix-build-8c53e2ba80e5/output/x86_64-linux-gnu/sv2-tp-8c53e2ba80e5-x86_64-linux-gnu.tar.gz

@Sjors Sjors merged commit 8c53e2b into stratum-mining:master Sep 1, 2025
10 checks passed
@fanquake fanquake deleted the more_gui_prune branch September 2, 2025 09:52
Sjors added a commit that referenced this pull request Oct 18, 2025
@Sjors
Sv2: silence MSan warnings
ff4b609 
- mark the SHA256 digest returned from Sv2SignatureNoiseMessage::GetHash()
  as initialized so MSan stops flagging the certificate hash
- clear the chain name literals and resulting base params object used by
  Sv2BasicTestingSetup when selecting regtest

This still fails:

==198==WARNING: MemorySanitizer: use-of-uninitialized-value
    #0 0x55b5ca320949 in basic_string /cxx_build/include/c++/v1/string:1003:9
    #1 0x55b5ca320949 in CBaseChainParams /src/sv2-tp/build_fuzz/src/./chainparamsbase.h:29:55
    #2 0x55b5ca320949 in std::__1::unique_ptr<CBaseChainParams, std::__1::default_delete<CBaseChainParams>> std::__1::make_unique[abi:de210103]<CBaseChainParams, char const (&) [8], int, int, 0>(char const (&) [8], int&&, int&&) /cxx_build/include/c++/v1/__memory/unique_ptr.h:759:30
    #3 0x55b5ca31e66f in CreateBaseChainParams(ChainType) /src/sv2-tp/build_fuzz/src/./chainparamsbase.cpp:48:16
    #4 0x55b5ca31dce5 in SelectBaseParams(ChainType) /src/sv2-tp/build_fuzz/src/./chainparamsbase.cpp:55:29
    #5 0x55b5ca2e4cad in Sv2BasicTestingSetup::Sv2BasicTestingSetup() /src/sv2-tp/build_fuzz/src/test/fuzz/./test/sv2_test_setup.cpp:34:5
    #6 0x55b5ca2c381a in std::__1::unique_ptr<Sv2BasicTestingSetup const, std::__1::default_delete<Sv2BasicTestingSetup const>> std::__1::make_unique[abi:de210103]<Sv2BasicTestingSetup const, 0>() /cxx_build/include/c++/v1/__memory/unique_ptr.h:759:30
    #7 0x55b5ca2c339e in (anonymous namespace)::Initialize() /src/sv2-tp/build_fuzz/src/test/fuzz/./test/fuzz/sv2_noise.cpp:32:39
    #8 0x55b5ca2ca01d in __invoke<void (*&)()> /cxx_build/include/c++/v1/__type_traits/invoke.h:87:27
    #9 0x55b5ca2ca01d in __call<void (*&)()> /cxx_build/include/c++/v1/__type_traits/invoke.h:342:5
    #10 0x55b5ca2ca01d in __invoke_r<void, void (*&)()> /cxx_build/include/c++/v1/__type_traits/invoke.h:348:10
    #11 0x55b5ca2ca01d in std::__1::__function::__func<void (*)(), void ()>::operator()() /cxx_build/include/c++/v1/__functional/function.h:174:12
    #12 0x55b5ca2b9622 in operator() /cxx_build/include/c++/v1/__functional/function.h:274:12
    #13 0x55b5ca2b9622 in operator() /cxx_build/include/c++/v1/__functional/function.h:772:10
    #14 0x55b5ca2b9622 in initialize /src/sv2-tp/build_fuzz/src/test/fuzz/./test/fuzz/fuzz.cpp:247:5
    #15 0x55b5ca2b9622 in LLVMFuzzerInitialize /src/sv2-tp/build_fuzz/src/test/fuzz/./test/fuzz/fuzz.cpp:321:5
    #16 0x55b5ca21df42 in fuzzer::FuzzerDriver(int*, char***, int (*)(unsigned char const*, unsigned long)) /llvm-project/compiler-rt/lib/fuzzer/FuzzerDriver.cpp:652:5
    #17 0x55b5ca24cfa2 in main /llvm-project/compiler-rt/lib/fuzzer/FuzzerMain.cpp:20:10
    #18 0x7f0f188e4082 in __libc_start_main (/tmp/not-out/tmp_tv4p4q7/libc.so.6+0x24082) (BuildId: 5792732f783158c66fb4f3756458ca24e46e827d)
    #19 0x55b5ca17802d in _start (/tmp/not-out/tmp_tv4p4q7/sv2_noise_cipher_roundtrip+0x24202d) (BuildId: 4d0ffc8495228d8cab1595a0fea7fa76c40aa18b)
DEDUP_TOKEN: basic_string--CBaseChainParams--std::__1::unique_ptr<CBaseChainParams, std::__1::default_delete<CBaseChainParams>> std::__1::make_unique[abi:de210103]<CBaseChainParams, char const (&) [8], int, int, 0>(char const (&) [8], int&&, int&&)
  Uninitialized value was created by an allocation of 'ref.tmp' in the stack frame
    #0 0x55b5ca32023c in std::__1::unique_ptr<CBaseChainParams, std::__1::default_delete<CBaseChainParams>> std::__1::make_unique[abi:de210103]<CBaseChainParams, char const (&) [8], int, int, 0>(char const (&) [8], int&&, int&&) /cxx_build/include/c++/v1/__memory/unique_ptr.h:759:34
DEDUP_TOKEN: std::__1::unique_ptr<CBaseChainParams, std::__1::default_delete<CBaseChainParams>> std::__1::make_unique[abi:de210103]<CBaseChainParams, char const (&) [8], int, int, 0>(char const (&) [8], int&&, int&&)
SUMMARY: MemorySanitizer: use-of-uninitialized-value /src/sv2-tp/build_fuzz/src/./chainparamsbase.h:29:55 in CBaseChainParams

Assisted-by: GitHub Copilot
Assisted-by: OpenAI GPT-5-Codex
Sjors added a commit that referenced this pull request Oct 21, 2025
@Sjors
Sv2: silence MSan warnings
fe45598 
- mark the SHA256 digest returned from Sv2SignatureNoiseMessage::GetHash()
  as initialized so MSan stops flagging the certificate hash
- clear the chain name literals and resulting base params object used by
  Sv2BasicTestingSetup when selecting regtest

This still fails:

==198==WARNING: MemorySanitizer: use-of-uninitialized-value
    #0 0x55b5ca320949 in basic_string /cxx_build/include/c++/v1/string:1003:9
    #1 0x55b5ca320949 in CBaseChainParams /src/sv2-tp/build_fuzz/src/./chainparamsbase.h:29:55
    #2 0x55b5ca320949 in std::__1::unique_ptr<CBaseChainParams, std::__1::default_delete<CBaseChainParams>> std::__1::make_unique[abi:de210103]<CBaseChainParams, char const (&) [8], int, int, 0>(char const (&) [8], int&&, int&&) /cxx_build/include/c++/v1/__memory/unique_ptr.h:759:30
    #3 0x55b5ca31e66f in CreateBaseChainParams(ChainType) /src/sv2-tp/build_fuzz/src/./chainparamsbase.cpp:48:16
    #4 0x55b5ca31dce5 in SelectBaseParams(ChainType) /src/sv2-tp/build_fuzz/src/./chainparamsbase.cpp:55:29
    #5 0x55b5ca2e4cad in Sv2BasicTestingSetup::Sv2BasicTestingSetup() /src/sv2-tp/build_fuzz/src/test/fuzz/./test/sv2_test_setup.cpp:34:5
    #6 0x55b5ca2c381a in std::__1::unique_ptr<Sv2BasicTestingSetup const, std::__1::default_delete<Sv2BasicTestingSetup const>> std::__1::make_unique[abi:de210103]<Sv2BasicTestingSetup const, 0>() /cxx_build/include/c++/v1/__memory/unique_ptr.h:759:30
    #7 0x55b5ca2c339e in (anonymous namespace)::Initialize() /src/sv2-tp/build_fuzz/src/test/fuzz/./test/fuzz/sv2_noise.cpp:32:39
    #8 0x55b5ca2ca01d in __invoke<void (*&)()> /cxx_build/include/c++/v1/__type_traits/invoke.h:87:27
    #9 0x55b5ca2ca01d in __call<void (*&)()> /cxx_build/include/c++/v1/__type_traits/invoke.h:342:5
    #10 0x55b5ca2ca01d in __invoke_r<void, void (*&)()> /cxx_build/include/c++/v1/__type_traits/invoke.h:348:10
    #11 0x55b5ca2ca01d in std::__1::__function::__func<void (*)(), void ()>::operator()() /cxx_build/include/c++/v1/__functional/function.h:174:12
    #12 0x55b5ca2b9622 in operator() /cxx_build/include/c++/v1/__functional/function.h:274:12
    #13 0x55b5ca2b9622 in operator() /cxx_build/include/c++/v1/__functional/function.h:772:10
    #14 0x55b5ca2b9622 in initialize /src/sv2-tp/build_fuzz/src/test/fuzz/./test/fuzz/fuzz.cpp:247:5
    #15 0x55b5ca2b9622 in LLVMFuzzerInitialize /src/sv2-tp/build_fuzz/src/test/fuzz/./test/fuzz/fuzz.cpp:321:5
    #16 0x55b5ca21df42 in fuzzer::FuzzerDriver(int*, char***, int (*)(unsigned char const*, unsigned long)) /llvm-project/compiler-rt/lib/fuzzer/FuzzerDriver.cpp:652:5
    #17 0x55b5ca24cfa2 in main /llvm-project/compiler-rt/lib/fuzzer/FuzzerMain.cpp:20:10
    #18 0x7f0f188e4082 in __libc_start_main (/tmp/not-out/tmp_tv4p4q7/libc.so.6+0x24082) (BuildId: 5792732f783158c66fb4f3756458ca24e46e827d)
    #19 0x55b5ca17802d in _start (/tmp/not-out/tmp_tv4p4q7/sv2_noise_cipher_roundtrip+0x24202d) (BuildId: 4d0ffc8495228d8cab1595a0fea7fa76c40aa18b)
DEDUP_TOKEN: basic_string--CBaseChainParams--std::__1::unique_ptr<CBaseChainParams, std::__1::default_delete<CBaseChainParams>> std::__1::make_unique[abi:de210103]<CBaseChainParams, char const (&) [8], int, int, 0>(char const (&) [8], int&&, int&&)
  Uninitialized value was created by an allocation of 'ref.tmp' in the stack frame
    #0 0x55b5ca32023c in std::__1::unique_ptr<CBaseChainParams, std::__1::default_delete<CBaseChainParams>> std::__1::make_unique[abi:de210103]<CBaseChainParams, char const (&) [8], int, int, 0>(char const (&) [8], int&&, int&&) /cxx_build/include/c++/v1/__memory/unique_ptr.h:759:34
DEDUP_TOKEN: std::__1::unique_ptr<CBaseChainParams, std::__1::default_delete<CBaseChainParams>> std::__1::make_unique[abi:de210103]<CBaseChainParams, char const (&) [8], int, int, 0>(char const (&) [8], int&&, int&&)
SUMMARY: MemorySanitizer: use-of-uninitialized-value /src/sv2-tp/build_fuzz/src/./chainparamsbase.h:29:55 in CBaseChainParams

Assisted-by: GitHub Copilot
Assisted-by: OpenAI GPT-5-Codex
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@fanquake @Sjors