use eth_chainId instead of net_version #3804
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etan-status
approved these changes
Jun 27, 2022
Contributor
etan-status
left a comment
etan-status
left a comment
There was a problem hiding this comment.
Nice that all major ELs implement this and no fallback seems necessary.
| fatal "The specified web3 provider serves data for a different chain", | ||
| expectedChain, providerChain | ||
| quit 1 | ||
| except CatchableError as exc: |
Contributor
There was a problem hiding this comment.
Shouldn't DataProviderFailure be enough here?
Contributor
Author
There was a problem hiding this comment.
Maybe. Didn't want to risk it, because debugging that in an async context is problematic.
Contributor
Author
There was a problem hiding this comment.
Also, {.push raises: [Defect].} effectively doesn't apply to {.async.} functions, which means that even if currently, DataProviderFailure might be enough, changes in the library implementation could undermine that with no compiler-time warnings or errors.
Co-authored-by: Etan Kissling <[email protected]>
zah
pushed a commit
that referenced
this pull request
Jun 28, 2022
* use eth_chainId instead of net_version * Update beacon_chain/eth1/eth1_monitor.nim Co-authored-by: Etan Kissling <[email protected]> * fix logging for Quantity types Co-authored-by: Etan Kissling <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
net_versionisn't one of the supported engine API methods in https://github.com/ethereum/execution-apis/blob/main/src/engine/specification.md#underlying-protocol whileeth_chainIdis.Until ethereum/go-ethereum#25166 was merged, Geth effectively didn't support
eth_chainIdin merge networks in situations where it mattered, but with that fixed, it's now worth switching Nimbus to use it.Tested with
rm ~/.ethereum/ -rv && go-ethereum/build/bin/geth --http --mainnetandbuild/nimbus_beacon_node --network=mainnet web3 test --url=http://127.0.0.1:8545rm ~/.ethereum/ -rv && go-ethereum/build/bin/geth --http --ropstenandbuild/nimbus_beacon_node --network=ropsten web3 test --url=http://127.0.0.1:8545rm ~/.ethereum/ -rv && go-ethereum/build/bin/geth --http --goerliandbuild/nimbus_beacon_node --network=prater web3 test --url=http://127.0.0.1:8545rm ~/.ethereum/ -rv && go-ethereum/build/bin/geth --http --sepoliaandbuild/nimbus_beacon_node --network=sepolia web3 test --url=http://127.0.0.1:8545