Change enum name + use null value when omitted

Signed-off-by: Filip Hrisafov <[email protected]>

Author: filiphr

spring-boot-project/spring-boot-autoconfigure/src/main/java/org/springframework/boot/autoconfigure/session/SessionAutoConfiguration.java

@@ -97,9 +97,7 @@ DefaultCookieSerializer cookieSerializer(ServerProperties serverProperties,
 			map.from(cookie::getHttpOnly).to(cookieSerializer::setUseHttpOnlyCookie);
 			map.from(cookie::getSecure).to(cookieSerializer::setUseSecureCookie);
 			map.from(cookie::getMaxAge).asInt(Duration::getSeconds).to(cookieSerializer::setCookieMaxAge);
-			map.from(cookie::getSameSite)
-				.as((sameSite) -> (sameSite == SameSite.UNSET) ? null : sameSite.attributeValue())
-				.to(cookieSerializer::setSameSite);
+			map.from(cookie::getSameSite).as(SameSite::attributeValue).to(cookieSerializer::setSameSite);
 			map.from(cookie::getPartitioned).to(cookieSerializer::setPartitioned);
 			cookieSerializerCustomizers.orderedStream().forEach((customizer) -> customizer.customize(cookieSerializer));
 			return cookieSerializer;

spring-boot-project/spring-boot-autoconfigure/src/main/java/org/springframework/boot/autoconfigure/web/reactive/WebSessionIdResolverAutoConfiguration.java

@@ -77,8 +77,7 @@ private void initializeCookie(ResponseCookieBuilder builder) {
 		map.from(cookie::getSecure).to(builder::secure);
 		map.from(cookie::getMaxAge).to(builder::maxAge);
 		map.from(cookie::getPartitioned).to(builder::partitioned);
-		map.from(cookie::getSameSite)
-			.to(((sameSite) -> builder.sameSite((sameSite == SameSite.UNSET) ? null : sameSite.attributeValue())));
+		map.from(cookie::getSameSite).as(SameSite::attributeValue).to(builder::sameSite);
 	}
 
 }

spring-boot-project/spring-boot-autoconfigure/src/test/java/org/springframework/boot/autoconfigure/session/SessionAutoConfigurationTests.java

@@ -171,9 +171,9 @@ void sessionCookieConfigurationIsAppliedToAutoConfiguredCookieSerializer() {
 	}
 
 	@Test
-	void sessionCookieSameSiteUnsetIsAppliedToAutoConfiguredCookieSerializer() {
+	void sessionCookieSameSiteOmittedIsAppliedToAutoConfiguredCookieSerializer() {
 		this.contextRunner.withUserConfiguration(SessionRepositoryConfiguration.class)
-			.withPropertyValues("server.servlet.session.cookie.sameSite=unset")
+			.withPropertyValues("server.servlet.session.cookie.sameSite=omitted")
 			.run((context) -> {
 				DefaultCookieSerializer cookieSerializer = context.getBean(DefaultCookieSerializer.class);
 				assertThat(cookieSerializer).hasFieldOrPropertyWithValue("sameSite", null);

spring-boot-project/spring-boot-autoconfigure/src/test/java/org/springframework/boot/autoconfigure/web/reactive/WebFluxAutoConfigurationTests.java

@@ -677,8 +677,8 @@ void customSessionCookieConfigurationShouldBeApplied() {
 	}
 
 	@Test
-	void sessionCookieUnsetConfigurationShouldBeApplied() {
-		this.contextRunner.withPropertyValues("server.reactive.session.cookie.same-site:unset")
+	void sessionCookieOmittedConfigurationShouldBeApplied() {
+		this.contextRunner.withPropertyValues("server.reactive.session.cookie.same-site:omitted")
 			.run(assertExchangeWithSession((exchange) -> {
 				List<ResponseCookie> cookies = exchange.getResponse().getCookies().get("SESSION");
 				assertThat(cookies).extracting(ResponseCookie::getSameSite).containsOnlyNulls();

spring-boot-project/spring-boot/src/main/java/org/springframework/boot/web/embedded/jetty/JettyServletWebServerFactory.java

@@ -284,7 +284,7 @@ protected final void configureWebAppContext(WebAppContext context, ServletContex
 	private void configureSession(WebAppContext context) {
 		SessionHandler handler = context.getSessionHandler();
 		SameSite sessionSameSite = getSession().getCookie().getSameSite();
-		if (sessionSameSite != null && sessionSameSite != SameSite.UNSET) {
+		if (sessionSameSite != null && sessionSameSite != SameSite.OMITTED) {
 			handler.setSameSite(HttpCookie.SameSite.valueOf(sessionSameSite.name()));
 		}
 		Duration sessionTimeout = getSession().getTimeout();

spring-boot-project/spring-boot/src/main/java/org/springframework/boot/web/embedded/tomcat/TomcatServletWebServerFactory.java

@@ -998,11 +998,12 @@ private static class SuppliedSameSiteCookieProcessor extends Rfc6265CookieProces
 		@Override
 		public String generateHeader(Cookie cookie, HttpServletRequest request) {
 			SameSite sameSite = getSameSite(cookie);
-			if (sameSite == null || sameSite == SameSite.UNSET) {
+			String sameSiteValue = (sameSite != null) ? sameSite.attributeValue() : null;
+			if (sameSiteValue == null) {
 				return super.generateHeader(cookie, request);
 			}
 			Rfc6265CookieProcessor delegate = new Rfc6265CookieProcessor();
-			delegate.setSameSiteCookies(sameSite.attributeValue());
+			delegate.setSameSiteCookies(sameSiteValue);
 			return delegate.generateHeader(cookie, request);
 		}
 

spring-boot-project/spring-boot/src/main/java/org/springframework/boot/web/embedded/undertow/UndertowServletWebServerFactory.java

@@ -635,7 +635,7 @@ public void handleRequest(HttpServerExchange exchange) throws Exception {
 		private void beforeCommit(HttpServerExchange exchange) {
 			for (Cookie cookie : exchange.responseCookies()) {
 				SameSite sameSite = getSameSite(asServletCookie(cookie));
-				if (sameSite == SameSite.UNSET) {
+				if (sameSite == SameSite.OMITTED) {
 					cookie.setSameSite(false);
 				}
 				else if (sameSite != null) {

spring-boot-project/spring-boot/src/main/java/org/springframework/boot/web/server/Cookie.java

@@ -146,9 +146,9 @@ public void setPartitioned(Boolean partitioned) {
 	public enum SameSite {
 
 		/**
-		 * Don't set the SameSite cookie attribute.
+		 * The SameSite cookie attribute will be omitted when creating the cookie.
 		 */
-		UNSET("Unset"),
+		OMITTED(null),
 
 		/**
 		 * Cookies are sent in both first-party and cross-origin requests.

spring-boot-project/spring-boot/src/test/java/org/springframework/boot/web/servlet/server/AbstractServletWebServerFactoryTests.java

@@ -881,7 +881,7 @@ void sessionCookieConfiguration() {
 	}
 
 	@ParameterizedTest
-	@EnumSource(mode = EnumSource.Mode.EXCLUDE, names = "UNSET")
+	@EnumSource(mode = EnumSource.Mode.EXCLUDE, names = "OMITTED")
 	void sessionCookieSameSiteAttributeCanBeConfiguredAndOnlyAffectsSessionCookies(SameSite sameSite) throws Exception {
 		AbstractServletWebServerFactory factory = getFactory();
 		factory.getSession().getCookie().setSameSite(sameSite);
@@ -896,7 +896,7 @@ void sessionCookieSameSiteAttributeCanBeConfiguredAndOnlyAffectsSessionCookies(S
 	}
 
 	@ParameterizedTest
-	@EnumSource(mode = EnumSource.Mode.EXCLUDE, names = "UNSET")
+	@EnumSource(mode = EnumSource.Mode.EXCLUDE, names = "OMITTED")
 	void sessionCookieSameSiteAttributeCanBeConfiguredAndOnlyAffectsSessionCookiesWhenUsingCustomName(SameSite sameSite)
 			throws Exception {
 		AbstractServletWebServerFactory factory = getFactory();
@@ -950,9 +950,9 @@ void cookieSameSiteSuppliersShouldNotAffectSessionCookie() throws IOException, U
 	}
 
 	@Test
-	void cookieSameSiteSuppliersShouldNotAffectUnsetSameSite() throws IOException, URISyntaxException {
+	void cookieSameSiteSuppliersShouldNotAffectOmittedSameSite() throws IOException, URISyntaxException {
 		AbstractServletWebServerFactory factory = getFactory();
-		factory.getSession().getCookie().setSameSite(SameSite.UNSET);
+		factory.getSession().getCookie().setSameSite(SameSite.OMITTED);
 		factory.getSession().getCookie().setName("SESSIONCOOKIE");
 		factory.addCookieSameSiteSuppliers(CookieSameSiteSupplier.ofStrict());
 		factory.addInitializers(new ServletRegistrationBean<>(new CookieServlet(false), "/"));