feat: move to netstandard2.0 for full framework support (#168)

codito · web-flow · commit 84266a6f8f9d · 2025-03-14T17:29:28.000+05:30
diff --git a/Directory.Build.props b/Directory.Build.props
@@ -20,9 +20,10 @@
 
     CS1573: Parameter 'parameter' has no matching param tag in the XML comment for 'parameter' (but other parameters do)
     CS1591: Missing XML comment for publicly visible type or member 'Type_or_Member'
+    CS0436: Type conflicts with imported type. Disabled to allow override of ExcludeFromCodeCoverage with assembly level target.
     -->
     <GenerateDocumentationFile>true</GenerateDocumentationFile>
-    <NoWarn>$(NoWarn),1573,1591,1712</NoWarn>
+    <NoWarn>$(NoWarn),1573,1591,1712,0436</NoWarn>
 
     <!-- Show full paths for the warnings and errors -->
     <GenerateFullPaths>true</GenerateFullPaths>
diff --git a/src/JUnit.Xml.Package/JUnit.Xml.Package.csproj b/src/JUnit.Xml.Package/JUnit.Xml.Package.csproj
@@ -5,7 +5,7 @@
   </PropertyGroup>
 
   <PropertyGroup>
-    <TargetFramework>netstandard2.1</TargetFramework>
+    <TargetFramework>netstandard2.0</TargetFramework>
     <Version>$(PackageVersion)</Version>
     <AssemblyName>JUnitXml.TestLogger</AssemblyName>
 
diff --git a/src/JUnit.Xml.Package/JUnitXml.TestLogger.nuspec b/src/JUnit.Xml.Package/JUnitXml.TestLogger.nuspec
@@ -16,7 +16,7 @@
     <file src="Microsoft.VisualStudio.TestPlatform.Extension.Junit.Xml.TestLogger.dll" target="build\_common\" />
     <file src="Spekt.TestLogger.dll" target="build\_common\" />
 
-    <file src="JunitXml.TestLogger.props" target="build\netstandard2.1\" />
+    <file src="JunitXml.TestLogger.props" target="build\netstandard2.0\" />
 
     <file src="README.md" target="docs\" />
     <file src="CHANGELOG.md" target="docs\" />
diff --git a/src/JUnit.Xml.TestLogger/Assembly.cs b/src/JUnit.Xml.TestLogger/Assembly.cs
@@ -8,3 +8,11 @@
 using System.Diagnostics.CodeAnalysis;
 
 [assembly: ExcludeFromCodeCoverage]
+
+namespace System.Diagnostics.CodeAnalysis;
+
+[AttributeUsage(AttributeTargets.Assembly | AttributeTargets.Class | AttributeTargets.Constructor | AttributeTargets.Event | AttributeTargets.Method | AttributeTargets.Property | AttributeTargets.Struct, AllowMultiple = false, Inherited = false)]
+internal sealed class ExcludeFromCodeCoverageAttribute : Attribute
+{
+	public ExcludeFromCodeCoverageAttribute() { }
+}
diff --git a/src/JUnit.Xml.TestLogger/JUnit.Xml.TestLogger.csproj b/src/JUnit.Xml.TestLogger/JUnit.Xml.TestLogger.csproj
@@ -1,7 +1,7 @@
 ﻿<Project Sdk="Microsoft.NET.Sdk">
 
   <PropertyGroup>
-    <TargetFramework>netstandard2.1</TargetFramework>
+    <TargetFramework>netstandard2.0</TargetFramework>
     <AssemblyName>Microsoft.VisualStudio.TestPlatform.Extension.JUnit.Xml.TestLogger</AssemblyName>
     <IsPackable>false</IsPackable>
   </PropertyGroup>
diff --git a/src/NUnit.Xml.Package/NUnit.Xml.Package.csproj b/src/NUnit.Xml.Package/NUnit.Xml.Package.csproj
@@ -1,7 +1,7 @@
 <Project Sdk="Microsoft.NET.Sdk">
 
   <PropertyGroup>
-    <TargetFramework>netstandard2.1</TargetFramework>
+    <TargetFramework>netstandard2.0</TargetFramework>
     <Version>$(PackageVersion)</Version>
     <AssemblyName>NUnitXml.TestLogger</AssemblyName>
 
diff --git a/src/NUnit.Xml.TestLogger/Assembly.cs b/src/NUnit.Xml.TestLogger/Assembly.cs
@@ -8,3 +8,11 @@
 using System.Diagnostics.CodeAnalysis;
 
 [assembly: ExcludeFromCodeCoverage]
+
+namespace System.Diagnostics.CodeAnalysis;
+
+[AttributeUsage(AttributeTargets.Assembly | AttributeTargets.Class | AttributeTargets.Constructor | AttributeTargets.Event | AttributeTargets.Method | AttributeTargets.Property | AttributeTargets.Struct, AllowMultiple = false, Inherited = false)]
+internal sealed class ExcludeFromCodeCoverageAttribute : Attribute
+{
+    public ExcludeFromCodeCoverageAttribute() { }
+}
diff --git a/src/NUnit.Xml.TestLogger/NUnit.Xml.TestLogger.csproj b/src/NUnit.Xml.TestLogger/NUnit.Xml.TestLogger.csproj
@@ -1,7 +1,7 @@
 ﻿<Project Sdk="Microsoft.NET.Sdk">
 
   <PropertyGroup>
-    <TargetFramework>netstandard2.1</TargetFramework>
+    <TargetFramework>netstandard2.0</TargetFramework>
     <AssemblyName>Microsoft.VisualStudio.TestPlatform.Extension.NUnit.Xml.TestLogger</AssemblyName>
     <IsPackable>false</IsPackable>
   </PropertyGroup>
diff --git a/src/TestLogger/Assembly.cs b/src/TestLogger/Assembly.cs
@@ -12,3 +12,11 @@
 [assembly: InternalsVisibleTo("Json.TestAdapter")]
 [assembly: InternalsVisibleTo("TestLogger.UnitTests")]
 [assembly: ExcludeFromCodeCoverage]
+
+namespace System.Diagnostics.CodeAnalysis;
+
+[AttributeUsage(AttributeTargets.Assembly | AttributeTargets.Class | AttributeTargets.Constructor | AttributeTargets.Event | AttributeTargets.Method | AttributeTargets.Property | AttributeTargets.Struct, AllowMultiple = false, Inherited = false)]
+internal sealed class ExcludeFromCodeCoverageAttribute : Attribute
+{
+    public ExcludeFromCodeCoverageAttribute() { }
+}
diff --git a/src/TestLogger/TestLogger.csproj b/src/TestLogger/TestLogger.csproj
@@ -1,7 +1,7 @@
 ﻿<Project Sdk="Microsoft.NET.Sdk">
 
   <PropertyGroup>
-    <TargetFramework>netstandard2.1</TargetFramework>
+    <TargetFramework>netstandard2.0</TargetFramework>
     <AssemblyName>Spekt.TestLogger</AssemblyName>
     <Version>$(PackageVersion)</Version>
     <IsPackable>true</IsPackable>
diff --git a/src/Xunit.Xml.Package/Xunit.Xml.Package.csproj b/src/Xunit.Xml.Package/Xunit.Xml.Package.csproj
@@ -1,7 +1,7 @@
 <Project Sdk="Microsoft.NET.Sdk">
 
   <PropertyGroup>
-    <TargetFramework>netstandard2.1</TargetFramework>
+    <TargetFramework>netstandard2.0</TargetFramework>
     <Version>$(PackageVersion)</Version>
     <AssemblyName>XunitXml.TestLogger</AssemblyName>
 
diff --git a/src/Xunit.Xml.Package/XunitXml.TestLogger.nuspec b/src/Xunit.Xml.Package/XunitXml.TestLogger.nuspec
@@ -19,6 +19,6 @@
     <file src="CHANGELOG.md" target="docs\" />
     <file src="packageIcon.png" target="\" />
 
-    <file src="XunitXml.TestLogger.props" target="build\netstandard2.1\" />
+    <file src="XunitXml.TestLogger.props" target="build\netstandard2.0\" />
   </files>
 </package>
diff --git a/src/Xunit.Xml.TestLogger/Assembly.cs b/src/Xunit.Xml.TestLogger/Assembly.cs
@@ -8,3 +8,11 @@
 using System.Diagnostics.CodeAnalysis;
 
 [assembly: ExcludeFromCodeCoverage]
+
+namespace System.Diagnostics.CodeAnalysis;
+
+[AttributeUsage(AttributeTargets.Assembly | AttributeTargets.Class | AttributeTargets.Constructor | AttributeTargets.Event | AttributeTargets.Method | AttributeTargets.Property | AttributeTargets.Struct, AllowMultiple = false, Inherited = false)]
+internal sealed class ExcludeFromCodeCoverageAttribute : Attribute
+{
+    public ExcludeFromCodeCoverageAttribute() { }
+}
diff --git a/src/Xunit.Xml.TestLogger/Xunit.Xml.TestLogger.csproj b/src/Xunit.Xml.TestLogger/Xunit.Xml.TestLogger.csproj
@@ -1,7 +1,7 @@
 ﻿<Project Sdk="Microsoft.NET.Sdk">
 
   <PropertyGroup>
-    <TargetFramework>netstandard2.1</TargetFramework>
+    <TargetFramework>netstandard2.0</TargetFramework>
     <AssemblyName>Microsoft.VisualStudio.TestPlatform.Extension.Xunit.Xml.TestLogger</AssemblyName>
     <Version>$(PackageVersion)</Version>
     <IsPackable>false</IsPackable>
diff --git a/test/Json.TestLogger.Package/Json.TestLogger.Package.csproj b/test/Json.TestLogger.Package/Json.TestLogger.Package.csproj
@@ -1,7 +1,7 @@
 <Project Sdk="Microsoft.NET.Sdk">
 
   <PropertyGroup>
-    <TargetFramework>netstandard2.1</TargetFramework>
+    <TargetFramework>netstandard2.0</TargetFramework>
     <Version>$(PackageVersion)</Version>
     <AssemblyName>Sample.Json.TestLogger</AssemblyName>
 
diff --git a/test/Json.TestLogger.TestAdapter/Json.TestLogger.TestAdapter.csproj b/test/Json.TestLogger.TestAdapter/Json.TestLogger.TestAdapter.csproj
@@ -1,7 +1,7 @@
 ﻿<Project Sdk="Microsoft.NET.Sdk">
 
   <PropertyGroup>
-    <TargetFramework>netstandard2.1</TargetFramework>
+    <TargetFramework>netstandard2.0</TargetFramework>
     <AssemblyName>Json.TestAdapter</AssemblyName>
     <Version>$(PackageVersion)</Version>
     <IsPackable>false</IsPackable>
diff --git a/test/Json.TestLogger/Json.TestLogger.csproj b/test/Json.TestLogger/Json.TestLogger.csproj
@@ -1,7 +1,7 @@
 ﻿<Project Sdk="Microsoft.NET.Sdk">
 
   <PropertyGroup>
-    <TargetFramework>netstandard2.1</TargetFramework>
+    <TargetFramework>netstandard2.0</TargetFramework>
     <AssemblyName>Json.TestLogger</AssemblyName>
     <Version>$(PackageVersion)</Version>
     <IsPackable>false</IsPackable>
