Changed how group overviews are sent to frontend

Author: Wong-ZZ

lib/cadet/course/groups.ex

@@ -3,16 +3,18 @@ defmodule Cadet.Course.Groups do
 
   alias Cadet.Course.Group
   import Cadet.Accounts  
-  
-  # Returns a map where the group names are the key and the value is
-  # another map with "avengerName" and "id" as the key
-  def get_group_info() do
+
+  def get_group_overviews() do
     Group
     |> Repo.all()
-    |> Enum.reduce(%{}, fn group, map -> Map.put(map, group.name, map_group_info(group))end)
+    |> Enum.map(fn group_info -> get_group_info(group_info) end)
   end
 
-  defp map_group_info(group) do
-    %{"avengerName" => get_user(group.leader_id).name, "id" => group.id}
+  defp get_group_info(group_info) do
+    %{
+      id: group_info.id, 
+      avenger_name: get_user(group_info.leader_id).name,
+      name: group_info.name
+    }
   end
 end

lib/cadet_web/controllers/group_controller.ex

@@ -1,19 +1,13 @@
 defmodule CadetWeb.GroupController do
-  @moduledoc """
-  Provides information about groups.
-  """
-
   use CadetWeb, :controller
+
   use PhoenixSwagger
 
-  import Cadet.Course.Groups
+  alias Cadet.Course.Groups
 
   def index(conn, _) do
-    group_info = get_group_info()
+    groups = Groups.get_group_overviews()
 
-    json(
-      conn,
-      group_info
-    )
+    render(conn, "index.json", groups: groups)
   end
 end

lib/cadet_web/views/group_view.ex

@@ -0,0 +1,16 @@
+defmodule CadetWeb.GroupView do
+  use CadetWeb, :view
+  use Timex
+
+  def render("index.json", %{groups: groups}) do
+    render_many(groups, CadetWeb.GroupView, "overview.json", as: :group)
+  end
+
+  def render("overview.json", %{group: group}) do
+    transform_map_for_view(group, %{
+      id: :id,
+      groupName: :name,
+      avengerName: :avenger_name
+    })
+  end
+end