Added tests

Author: Wong-ZZ

lib/cadet/course/groups.ex

@@ -16,19 +16,19 @@ defmodule Cadet.Course.Groups do
   @spec get_group_overviews(%User{}) :: [group_overview]
   def get_group_overviews(_user = %User{role: role}) do
     if role in @get_overviews_role do
-      overviews = 
+      overviews =
         Group
         |> Repo.all()
         |> Enum.map(fn group_info -> get_group_info(group_info) end)
       {:ok, overviews}
     else
-      {:error, {:unauthorised, "Unauthorised"}}
+      {:error, {:unauthorized, "Unauthorized"}}
     end
   end
 
   defp get_group_info(group_info) do
     %{
-      id: group_info.id, 
+      id: group_info.id,
       avenger_name: get_user(group_info.leader_id).name,
       name: group_info.name
     }

test/cadet/course/groups_test.exs

@@ -0,0 +1,16 @@
+defmodule Cadet.Course.GroupsTest do
+  use Cadet.DataCase
+
+  alias Cadet.Accounts
+  alias Cadet.Accounts.User
+  alias Cadet.Course.Groups
+
+  test "get group overviews" do
+    group = insert(:group)
+    {:ok, result} = Groups.get_group_overviews(%User{role: :staff})
+    avenger_name = Accounts.get_user(group.leader_id).name
+    group_name = group.name
+    group_id = group.id
+    assert result == [%{id: group_id, avenger_name: avenger_name, name: group_name}]
+  end
+end

test/cadet_web/controllers/group_controller_test.exs

@@ -0,0 +1,34 @@
+defmodule CadetWeb.GroupsControllerTest do
+  use CadetWeb.ConnCase
+
+  describe "GET /, unauthenticated" do
+    test "unauthorized", %{conn: conn} do
+      conn = get(conn, build_url())
+      assert response(conn, 401) =~ "Unauthorised"
+    end
+  end
+
+  describe "GET /, student only" do
+    @tag authenticate: :student
+    test "unauthorized", %{conn: conn} do
+      conn = get(conn, build_url())
+      assert response(conn, 401) == "Unauthorized"
+    end
+  end
+
+  describe "GET /, staff" do
+    @tag authenticate: :staff
+    test "successful", %{conn: conn} do
+      avenger = insert(:user, %{name: "avenger", role: :staff})
+      mentor = insert(:user, %{name: "mentor", role: :staff})
+      group = insert(:group, %{leader: avenger, mentor: mentor})
+      conn = get(conn, build_url())
+      group_name = group.name
+      group_id = group.id
+      expected = [%{"id" => group_id, "avengerName" => "avenger", "groupName" => group_name}]
+      assert json_response(conn, 200) == expected
+    end
+  end
+
+  defp build_url, do: "/v1/groups/"
+end