Fix documentation about default origins value. Update API.md #3464
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix documentation about default origins value. The default should read `*:*` instead of `*
Member
|
@JonaMX thanks! |
This was referenced Jan 7, 2021
This was referenced Mar 6, 2021
This was referenced Mar 13, 2021
Closed
This was referenced Mar 17, 2021
This was referenced May 26, 2021
This was referenced Nov 22, 2022
dzad
pushed a commit
to dzad/socket.io
that referenced
this pull request
May 29, 2023
Fix documentation about default origins value. The default should read `*:*` instead of `*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was struggling with CORS issues using explicitly the default origins value
*on development, a value that is retrieved from a.envfile, but turns out that the default is actually*:*.The kind of change this PR does introduce
Current documentation
origins (String): the allowed origins (
*)New documentation
origins (String): the allowed origins (
*:*)Other information (e.g. related issues)