[fix] Handle undefined case properly when decoding packet (#74)

Author: darrachequesne

lib/browser.js

@@ -222,8 +222,11 @@ exports.encodeBase64Packet = function(packet, callback) {
  */
 
 exports.decodePacket = function (data, binaryType, utf8decode) {
+  if (data === undefined) {
+    return err;
+  }
   // String data
-  if (typeof data == 'string' || data === undefined) {
+  if (typeof data == 'string') {
     if (data.charAt(0) == 'b') {
       return exports.decodeBase64Packet(data.substr(1), binaryType);
     }

lib/index.js

@@ -118,8 +118,11 @@ exports.encodeBase64Packet = function(packet, callback){
  */
 
 exports.decodePacket = function (data, binaryType, utf8decode) {
+  if (data === undefined) {
+    return err;
+  }
   // String data
-  if (typeof data == 'string' || data === undefined) {
+  if (typeof data == 'string') {
     if (data.charAt(0) == 'b') {
       return exports.decodeBase64Packet(data.substr(1), binaryType);
     }

test/parser.js

@@ -129,6 +129,10 @@ module.exports = function(parser) {
       describe('decoding error handing', function () {
         var err = { type: 'error', data: 'parser error' };
 
+        it('should disallow empty payload', function () {
+          expect(decode(undefined)).to.eql(err);
+        });
+
         it('should disallow bad format', function () {
           expect(decode(':::')).to.eql(err);
         });