Skip to content

SNOW-1708720: Error is raised at debug level when not closing connection #2090

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Oct 28, 2024
Merged

SNOW-1708720: Error is raised at debug level when not closing connection #2090

merged 5 commits into from
Oct 28, 2024

Conversation

@sfc-gh-yuwang
Copy link
Contributor

@sfc-gh-yuwang sfc-gh-yuwang commented Oct 26, 2024

Please answer these questions before submitting your pull requests. Thanks!

  1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes #NNNN

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am modifying authorization mechanisms
    • I am adding new credentials
    • I am modifying OCSP code
    • I am adding a new dependency

  3. Please describe how your code solves the related issue.

    Please write a short description of how your code change solves the related issue.

  4. (Optional) PR for stored-proc connector:

@sfc-gh-yuwang sfc-gh-yuwang added the NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md label Oct 26, 2024
sfc-gh-aling
sfc-gh-aling reviewed Oct 26, 2024
View reviewed changes
src/snowflake/connector/aio/_network.py Outdated
RuntimeError,
AttributeError, # json decoding error
) as err:
if "Event loop is closed" in str(err):
Copy link
Collaborator

@sfc-gh-aling sfc-gh-aling Oct 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we also check err type here to be more precise?

Suggested change
if "Event loop is closed" in str(err):
if "Event loop is closed" in str(err) and instance(err, ...):

sfc-gh-aling
sfc-gh-aling reviewed Oct 26, 2024
View reviewed changes
sfc-gh-aling
sfc-gh-aling reviewed Oct 26, 2024
View reviewed changes
sfc-gh-aling
sfc-gh-aling reviewed Oct 28, 2024
View reviewed changes
@sfc-gh-yuwang sfc-gh-yuwang merged commit edfaf1a into dev/aio-connector Oct 28, 2024
119 checks passed
@sfc-gh-yuwang sfc-gh-yuwang deleted the SNOW-1708720 branch October 28, 2024 20:45
@github-actions github-actions bot locked and limited conversation to collaborators Oct 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@sfc-gh-aling sfc-gh-aling sfc-gh-aling approved these changes

Assignees

No one assigned

Labels

NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sfc-gh-yuwang @sfc-gh-aling