Merge pull request #404 from smartdevicelink/bugfix/permission-filter-early-return

crokita · web-flow · commit 89784359f25c · 2021-03-23T09:40:14.000-04:00
Fix positioning of return statement in PermissionManager
diff --git a/lib/js/src/manager/permission/_PermissionManagerBase.js b/lib/js/src/manager/permission/_PermissionManagerBase.js
@@ -174,9 +174,8 @@ class _PermissionManagerBase extends _SubManagerBase {
             ) {
                 this._notifyListener(filter);
             }
-
-            return this;
         }
+        return this;
     }
 
     /**

Original file line number	Diff line number	Diff line change
`@@ -174,9 +174,8 @@ class _PermissionManagerBase extends _SubManagerBase {`
`174`	`174`	`) {`
`175`	`175`	`this._notifyListener(filter);`
`176`	`176`	`}`
`177`		`-`
`178`		`- return this;`
`179`	`177`	`}`
	`178`	`+ return this;`
`180`	`179`	`}`
`181`	`180`
`182`	`181`	`/**`