Remove cloning the ImageRPC in the clone method for SdlArtwork (#1821)

JulianKast · web-flow · commit ccf0af9faa46 · 2022-07-18T09:46:50.000-04:00
* Remove cloning the ImageRPC in the clone method for SdlArtwork

* Fix JavaSe artwork cloning method to match android

* Fix cloning sdlArtwork
diff --git a/android/sdl_android/src/main/java/com/smartdevicelink/managers/file/filetypes/SdlArtwork.java b/android/sdl_android/src/main/java/com/smartdevicelink/managers/file/filetypes/SdlArtwork.java
@@ -160,7 +160,7 @@ private Image createImageRPC() {
     public SdlArtwork clone() {
         SdlArtwork artwork = (SdlArtwork) super.clone();
         if (artwork != null) {
-            artwork.imageRPC = artwork.createImageRPC();
+            artwork.imageRPC = null;
             return artwork;
         }
         return null;
diff --git a/javaSE/javaSE/src/main/java/com/smartdevicelink/managers/file/filetypes/SdlArtwork.java b/javaSE/javaSE/src/main/java/com/smartdevicelink/managers/file/filetypes/SdlArtwork.java
@@ -160,7 +160,7 @@ private Image createImageRPC() {
     public SdlArtwork clone() {
         SdlArtwork artwork = (SdlArtwork) super.clone();
         if (artwork != null) {
-            artwork.imageRPC = artwork.createImageRPC();
+            artwork.imageRPC = null;
             return artwork;
         }
         return null;

Original file line number	Diff line number	Diff line change
`@@ -160,7 +160,7 @@ private Image createImageRPC() {`
`160`	`160`	`public SdlArtwork clone() {`
`161`	`161`	`SdlArtwork artwork = (SdlArtwork) super.clone();`
`162`	`162`	`if (artwork != null) {`
`163`		`- artwork.imageRPC = artwork.createImageRPC();`
	`163`	`+ artwork.imageRPC = null;`
`164`	`164`	`return artwork;`
`165`	`165`	`}`
`166`	`166`	`return null;`