Skip to content

Commit c7887a5

Browse files
authored
some minor fixes (#117)
1 parent a91a6d5 commit c7887a5

File tree

3 files changed

+6
-2
lines changed

3 files changed

+6
-2
lines changed

Project.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ Tables = "bd369af6-aec1-5ad0-b16a-f7cc5008161c"
2222

2323
[compat]
2424
Compat = "3.17, 4"
25-
DataAPI = "1.8"
25+
DataAPI = "1.16"
2626
InvertedIndices = "1"
2727
IteratorInterfaceExtensions = "0.1.1, 1"
2828
Missings = "0.4.2, 1"

src/InMemoryDatasets.jl

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,7 @@ import DataAPI,
2525
DataAPI.antijoin,
2626
DataAPI.nrow,
2727
DataAPI.ncol,
28+
DataAPI.groupby,
2829
# DataAPI.crossjoin,
2930
Tables,
3031
Tables.columnindex

src/abstractdataset/iteration.jl

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -394,7 +394,10 @@ Base.show(dfcs::DatasetColumns;
394394
# prevent using broadcasting to mutate columns e.g. in pop!.(eachcol(ds))
395395
# TODO customise Base.broadcasted to handle the situation
396396
for f in filter(x->occursin(r"!$", String(x)), names(Base))
397-
@eval Base.broadcasted(::typeof($f), ::DatasetColumns, args...) = throw(ArgumentError("broadcasting `$(nameof($f))` over DatasetColums is reserved."))
397+
# FIXME due to a bug in Julia > 1.11 !?
398+
if isdefined(Main, f)
399+
@eval Base.broadcasted(::typeof($f), ::DatasetColumns, args...) = throw(ArgumentError("broadcasting `$(nameof($f))` over DatasetColums is reserved."))
400+
end
398401
end
399402
for f in filter(x->occursin(r"!$", String(x)), names(Statistics))
400403
@eval Base.broadcasted(::typeof($f), ::DatasetColumns, args...) = throw(ArgumentError("broadcasting `$(nameof($f))` over DatasetColums is reserved."))

0 commit comments

Comments
 (0)