Workflow changes #24
Merged
Workflow changes #24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MasloMaslane
force-pushed
the
workflow-changes
branch
from
4a8b4db to
e969487
Compare
There was a problem hiding this comment.
Copilot reviewed 12 out of 14 changed files in this pull request and generated 2 comments.
Files not reviewed (2)
- example_workflows/example.json: Language not supported
- example_workflows/simple_run.json: Language not supported
Comments suppressed due to low confidence (1)
src/sio3pack/workflow/execution/mount_namespace.py:36
- [nitpick] The legacy conditional handling for 'data["source"]' is still present; consider removing this outdated code if all sources are now validated consistently.
if isinstance(data["source"], str): # TODO: delete this
| """ | ||
|
|
||
| READ = "read" | ||
| READ_WRTIE = "read_write" |
There was a problem hiding this comment.
The enum member 'READ_WRTIE' appears to be a typo; consider renaming it to 'READ_WRITE' to match standard naming conventions.
Suggested change
| READ_WRTIE = "read_write" | |
| READ_WRITE = "read_write" |
src/sio3pack/visualizer/cytoscope.py
Outdated
| } | ||
| ) | ||
|
|
||
| # Mark observablr objects as inputs for output object storage |
There was a problem hiding this comment.
The comment contains a spelling error ('observablr' should be 'observable'); please correct the typo.
Suggested change
| # Mark observablr objects as inputs for output object storage | |
| # Mark observable objects as inputs for output object storage |
* Start of workflow creation * Working outgen graph creation * Inwer * Running * User out workflow * Test run * Run formatters * Add compilation to workflows * Add more examples * Add proper limits handling * Run formatters * Fix tests * Refactor * Reformat
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.