no-single-promise-in-promise-methods: Suggest instead of fix when result is stored in array (#2385)

Author: Clement398

rules/no-single-promise-in-promise-methods.js

@@ -33,6 +33,9 @@ const isPromiseMethodCallWithSingleElementArray = node =>
 	&& node.arguments[0].elements[0]
 	&& node.arguments[0].elements[0].type !== 'SpreadElement';
 
+const isStoredInArray = node => isMethodCall(node, {methods: ['all']})
+	&& ['VariableDeclarator', 'AssignmentExpression'].includes(node.parent.parent.type);
+
 const unwrapAwaitedCallExpression = (callExpression, sourceCode) => fixer => {
 	const [promiseNode] = callExpression.arguments[0].elements;
 	let text = getParenthesizedText(promiseNode, sourceCode);
@@ -133,7 +136,15 @@ const create = context => ({
 			callExpression.parent.type === 'AwaitExpression'
 			&& callExpression.parent.argument === callExpression
 		) {
-			problem.fix = unwrapAwaitedCallExpression(callExpression, sourceCode);
+			if (isStoredInArray(callExpression)) {
+				problem.suggest = [{
+					messageId: MESSAGE_ID_SUGGESTION_UNWRAP,
+					fix: unwrapAwaitedCallExpression(callExpression, sourceCode),
+				}];
+			} else {
+				problem.fix = unwrapAwaitedCallExpression(callExpression, sourceCode);
+			}
+
 			return problem;
 		}
 

test/no-single-promise-in-promise-methods.mjs

@@ -39,6 +39,10 @@ test.snapshot({
 		'await Promise.race([promise])',
 		'await Promise.all([new Promise(() => {})])',
 		'+await Promise.all([+1])',
+		'const results = await Promise.all([promise])',
+		'results = await Promise.all([promise])',
+		'const results = await Promise.any([promise])',
+		'const results = await Promise.race([promise])',
 
 		// ASI, `Promise.all()` is not really `await`ed
 		outdent`

test/snapshots/no-single-promise-in-promise-methods.mjs.md

@@ -655,7 +655,87 @@ Generated by [AVA](https://avajs.dev).
         |                    ^^^^ Wrapping single-element array with \`Promise.all()\` is unnecessary.␊
     `
 
-## invalid(32): await Promise.all([(x,y)]) [0].toString()
+## invalid(32): const results = await Promise.all([promise])
+
+> Input
+
+    `␊
+      1 | const results = await Promise.all([promise])␊
+    `
+
+> Error 1/1
+
+    `␊
+    > 1 | const results = await Promise.all([promise])␊
+        |                                   ^^^^^^^^^ Wrapping single-element array with \`Promise.all()\` is unnecessary.␊
+    ␊
+    --------------------------------------------------------------------------------␊
+    Suggestion 1/1: Use the value directly.␊
+      1 | const results = await promise␊
+    `
+
+## invalid(33): results = await Promise.all([promise])
+
+> Input
+
+    `␊
+      1 | results = await Promise.all([promise])␊
+    `
+
+> Error 1/1
+
+    `␊
+    > 1 | results = await Promise.all([promise])␊
+        |                             ^^^^^^^^^ Wrapping single-element array with \`Promise.all()\` is unnecessary.␊
+    ␊
+    --------------------------------------------------------------------------------␊
+    Suggestion 1/1: Use the value directly.␊
+      1 | results = await promise␊
+    `
+
+## invalid(34): const results = await Promise.any([promise])
+
+> Input
+
+    `␊
+      1 | const results = await Promise.any([promise])␊
+    `
+
+> Output
+
+    `␊
+      1 | const results = await promise␊
+    `
+
+> Error 1/1
+
+    `␊
+    > 1 | const results = await Promise.any([promise])␊
+        |                                   ^^^^^^^^^ Wrapping single-element array with \`Promise.any()\` is unnecessary.␊
+    `
+
+## invalid(35): const results = await Promise.race([promise])
+
+> Input
+
+    `␊
+      1 | const results = await Promise.race([promise])␊
+    `
+
+> Output
+
+    `␊
+      1 | const results = await promise␊
+    `
+
+> Error 1/1
+
+    `␊
+    > 1 | const results = await Promise.race([promise])␊
+        |                                    ^^^^^^^^^ Wrapping single-element array with \`Promise.race()\` is unnecessary.␊
+    `
+
+## invalid(36): await Promise.all([(x,y)]) [0].toString()
 
 > Input