Code review fixes

Author: RaymondLuong3

src/SIL.XForge.Scripture/ClientApp/src/app/translate/draft-generation/draft-history-list/draft-history-entry/draft-history-entry.component.spec.ts

@@ -22,6 +22,7 @@ import { SFProjectService } from '../../../../core/sf-project.service';
 import { BuildDto } from '../../../../machine-api/build-dto';
 import { BuildStates } from '../../../../machine-api/build-states';
 import { DraftGenerationService } from '../../draft-generation.service';
+import { FORMATTING_OPTIONS_SUPPORTED_DATE } from '../../draft-utils';
 import { TrainingDataService } from '../../training-data/training-data.service';
 import { DraftHistoryEntryComponent } from './draft-history-entry.component';
 
@@ -33,8 +34,9 @@ const mockedTrainingDataService = mock(TrainingDataService);
 const mockedActivatedProjectService = mock(ActivatedProjectService);
 const mockedFeatureFlagsService = mock(FeatureFlagService);
 
-const dateBeforeFormattingSupported = '2025-09-01T12:00:00.000Z';
-const dateAfterFormattingSupported = '2025-10-01T12:00:00.000Z';
+const oneDay = 1000 * 60 * 60 * 24;
+const dateBeforeFormattingSupported = new Date(FORMATTING_OPTIONS_SUPPORTED_DATE.getTime() - oneDay).toISOString();
+const dateAfterFormattingSupported = new Date(FORMATTING_OPTIONS_SUPPORTED_DATE.getTime() + oneDay).toISOString();
 
 describe('DraftHistoryEntryComponent', () => {
   let component: DraftHistoryEntryComponent;
@@ -410,7 +412,7 @@ describe('DraftHistoryEntryComponent', () => {
       expect(fixture.nativeElement.querySelector('.require-formatting-options')).toBeNull();
     }));
 
-    it('should not show the USFM format option for drafts before the supported date', fakeAsync(() => {
+    it('should not show the USFM format option for drafts created before the supported date', fakeAsync(() => {
       const user = 'user-display-name';
       const date = dateBeforeFormattingSupported;
       const trainingBooks = ['EXO'];

src/SIL.XForge.Scripture/ClientApp/src/app/translate/editor/editor-draft/editor-draft.component.html

@@ -52,10 +52,10 @@
               </button>
             } @else if (formattingOptionsSupported) {
               <span
-                [matTooltip]="t(doesLatestHaveDraft ? 'format_draft_can' : 'format_draft_cannot')"
-                [style.cursor]="doesLatestHaveDraft ? 'pointer' : 'not-allowed'"
+                [matTooltip]="t(doesLatestBuildHaveDraft ? 'format_draft_can' : 'format_draft_cannot')"
+                [style.cursor]="doesLatestBuildHaveDraft ? 'pointer' : 'not-allowed'"
               >
-                <button mat-button (click)="navigateToFormatting()" [disabled]="!doesLatestHaveDraft">
+                <button mat-button (click)="navigateToFormatting()" [disabled]="!doesLatestBuildHaveDraft">
                   <mat-icon>build</mat-icon>
                   <transloco class="hide-lt-md" key="editor_draft_tab.format_draft"></transloco>
                   <transloco class="hide-gt-md" key="editor_draft_tab.formatting"></transloco>

src/SIL.XForge.Scripture/ClientApp/src/app/translate/editor/editor-draft/editor-draft.component.spec.ts

@@ -426,7 +426,7 @@ describe('EditorDraftComponent', () => {
       flush();
     }));
 
-    it('should hide formatting options of drafts before supported date', fakeAsync(() => {
+    it('should hide formatting options for drafts created before supported date', fakeAsync(() => {
       const testProjectDoc: SFProjectProfileDoc = {
         data: createTestProjectProfile({
           texts: [

src/SIL.XForge.Scripture/ClientApp/src/app/translate/editor/editor-draft/editor-draft.component.ts

@@ -115,7 +115,7 @@ export class EditorDraftComponent implements AfterViewInit, OnChanges {
     return this.draftHandlingService.canApplyDraft(this.targetProject, this.bookNum, this.chapter, this.draftDelta.ops);
   }
 
-  get doesLatestHaveDraft(): boolean {
+  get doesLatestBuildHaveDraft(): boolean {
     return (
       this.targetProject?.texts.find(t => t.bookNum === this.bookNum)?.chapters.find(c => c.number === this.chapter)
         ?.hasDraft ?? false
@@ -127,14 +127,13 @@ export class EditorDraftComponent implements AfterViewInit, OnChanges {
       this.featureFlags.usfmFormat.enabled &&
       !this.hasFormattingSelected &&
       this.formattingOptionsSupported &&
-      this.doesLatestHaveDraft
+      this.doesLatestBuildHaveDraft
     );
   }
 
   set draftRevisions(value: Revision[]) {
     this._draftRevisions = value;
-    const latestRevisionDate = value.length > 0 ? new Date(value[0].timestamp) : new Date(0);
-    this.formattingOptionsSupported = latestRevisionDate > FORMATTING_OPTIONS_SUPPORTED_DATE;
+    this.formattingOptionsSupported = value.some(rev => new Date(rev.timestamp) > FORMATTING_OPTIONS_SUPPORTED_DATE);
   }
 
   get draftRevisions(): Revision[] {