Be specific about draft ability in app.component.spec (#3445)

Avoid a potential race in what menu items test 'navigate to last
project' finds by specifying NmtDraftAuthGuard.allowTransition.

As such, expect a 10th menu item of "Generate draft".

This test also slightly increases the coupling of the named menu items
in the comment with the count of menu items expected, as well as
changing from "Manage questions" to "My progress".

Author: marksvc

src/SIL.XForge.Scripture/ClientApp/src/app/app.component.spec.ts

@@ -44,14 +44,15 @@ import { SF_TYPE_REGISTRY } from './core/models/sf-type-registry';
 import { SFProjectService } from './core/sf-project.service';
 import { NavigationComponent } from './navigation/navigation.component';
 import { GlobalNoticesComponent } from './shared/global-notices/global-notices.component';
-import { SettingsAuthGuard, SyncAuthGuard, UsersAuthGuard } from './shared/project-router.guard';
+import { NmtDraftAuthGuard, SettingsAuthGuard, SyncAuthGuard, UsersAuthGuard } from './shared/project-router.guard';
 import { paratextUsersFromRoles } from './shared/test-utils';
 
 const mockedAuthService = mock(AuthService);
 const mockedUserService = mock(UserService);
 const mockedSettingsAuthGuard = mock(SettingsAuthGuard);
 const mockedSyncAuthGuard = mock(SyncAuthGuard);
 const mockedUsersAuthGuard = mock(UsersAuthGuard);
+const mockedNmtDraftAuthGuard = mock(NmtDraftAuthGuard);
 const mockedSFProjectService = mock(SFProjectService);
 const mockedCookieService = mock(CookieService);
 const mockedLocationService = mock(LocationService);
@@ -102,6 +103,7 @@ describe('AppComponent', () => {
       { provide: SettingsAuthGuard, useMock: mockedSettingsAuthGuard },
       { provide: SyncAuthGuard, useMock: mockedSyncAuthGuard },
       { provide: UsersAuthGuard, useMock: mockedUsersAuthGuard },
+      { provide: NmtDraftAuthGuard, useMock: mockedNmtDraftAuthGuard },
       { provide: SFProjectService, useMock: mockedSFProjectService },
       { provide: CookieService, useMock: mockedCookieService },
       { provide: LocationService, useMock: mockedLocationService },
@@ -129,9 +131,20 @@ describe('AppComponent', () => {
 
     expect(env.isDrawerVisible).toEqual(true);
     expect(env.selectedProjectId).toEqual('project01');
-    // Translate | Overview | Edit & review | Community Checking | Manage questions | Questions & answers |
-    // Synchronize | Users | Settings
-    expect(env.menuLength).toEqual(9);
+
+    const expectedMenuItemCount = [
+      'Translate',
+      'Overview',
+      'Edit & review',
+      'Generate draft',
+      'Community Checking',
+      'My progress',
+      'Questions & answers',
+      'Sync with Paratext',
+      'Users',
+      'Settings'
+    ].length;
+    expect(env.menuLength).toEqual(expectedMenuItemCount);
     verify(mockedUserService.setCurrentProjectId(anything(), 'project01')).once();
     tick();
   }));
@@ -143,8 +156,15 @@ describe('AppComponent', () => {
 
     expect(env.isDrawerVisible).toEqual(true);
     expect(env.selectedProjectId).toEqual('project02');
-    // Expect: Community Checking | Manage Questions | Overview | Sync | Settings | Users
-    expect(env.menuLength).toEqual(6);
+    const expectedMenuItemCount: number = [
+      'Community Checking',
+      'My progress',
+      'Overview',
+      'Sync with Paratext',
+      'Settings',
+      'Users'
+    ].length;
+    expect(env.menuLength).toEqual(expectedMenuItemCount);
     verify(mockedUserService.setCurrentProjectId(anything(), 'project02')).once();
     discardPeriodicTasks();
   }));
@@ -700,6 +720,7 @@ class TestEnvironment {
     when(mockedSettingsAuthGuard.allowTransition(anything())).thenReturn(this.canSeeSettings$);
     when(mockedSyncAuthGuard.allowTransition(anything())).thenReturn(this.canSync$);
     when(mockedUsersAuthGuard.allowTransition(anything())).thenReturn(this.canSeeUsers$);
+    when(mockedNmtDraftAuthGuard.allowTransition(anything())).thenReturn(this.canSeeGenerateDraft$);
     when(mockedI18nService.localeCode).thenReturn('en');
     when(mockedUrlService.helps).thenReturn('helps');
     when(mockedUrlService.announcementPage).thenReturn('community-announcements');