Filter quote convention analysis by books/chapter

[Enkidu93]

Fixes #348

---

This change is 

[codecov-commenter]

Codecov Report

❌ Patch coverage is 78.26087% with 10 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (master@6f7d447). Learn more about missing BASE report.

Files with missing lines	Patch %	Lines
...Analysis/ParatextProjectQuoteConventionDetector.cs	44.44%	10 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff            @@
##             master     #349   +/-   ##
=========================================
  Coverage          ?   72.38%           
=========================================
  Files             ?      417           
  Lines             ?    35632           
  Branches          ?     4928           
=========================================
  Hits              ?    25793           
  Misses            ?     8744           
  Partials          ?     1095           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[ddaspit]

@ddaspit reviewed 8 of 8 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @Enkidu93)

---

src/SIL.Machine/PunctuationAnalysis/ParatextProjectQuoteConventionDetector.cs line 33 at r1 (raw file):

        public QuoteConventionAnalysis GetQuoteConventionAnalysis(
            QuoteConventionDetector handler = null,
            Dictionary<string, List<int>> includeChapters = null

It would be better if this were a read-only interface, if possible, i.e. IReadOnlyDictionary.

---

src/SIL.Machine/PunctuationAnalysis/UsfmStructureExtractor.cs line 26 at r1 (raw file):

        {
            _nextTextSegmentBuilder.AddPrecedingMarker(UsfmMarkerType.Chapter);
            _nextTextSegmentBuilder.SetChapter(int.Parse(number));

It might be safer to get the chapter number from state.VerseRef.

[Enkidu93]

Reviewable status: 4 of 8 files reviewed, 2 unresolved discussions (waiting on @ddaspit)

---

src/SIL.Machine/PunctuationAnalysis/ParatextProjectQuoteConventionDetector.cs line 33 at r1 (raw file):

Previously, ddaspit (Damien Daspit) wrote…

It would be better if this were a read-only interface, if possible, i.e. IReadOnlyDictionary.

Done.

---

src/SIL.Machine/PunctuationAnalysis/UsfmStructureExtractor.cs line 26 at r1 (raw file):

Previously, ddaspit (Damien Daspit) wrote…

It might be safer to get the chapter number from state.VerseRef.

Done. Put in a change to machine.py for consistency.

[ddaspit]

@ddaspit reviewed 4 of 4 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @Enkidu93)