Follow Up to addressing #1258 comments (#1260)

* fix Conversations Types

Author: jpsantosbh

packages/client/src/fabric/Conversation.ts

@@ -47,9 +47,7 @@ const isConversationChatEventParams = (
     typeof event === 'object' &&
     event !== null &&
     'subtype' in event &&
-    event.subtype === 'chat' &&
-    'user_name' in event &&
-    'text' in event
+    event.subtype === 'chat'
   )
 }
 
@@ -103,7 +101,7 @@ export class Conversation {
       if (chatCallbacks?.size) {
         // the backend includes the user_name if is chat event
         chatCallbacks.forEach((cb) =>
-          cb(event as unknown as ConversationChatEventParams)
+          cb(event)
         )
       }
     }
@@ -180,8 +178,7 @@ export class Conversation {
         await this.httpClient.fetch<GetConversationMessagesResponse>(
           makeQueryParamsUrls(path, queryParams)
         )
-      
-      
+
       return buildPaginatedResult<ConversationMessage>(
         body,
         this.httpClient.fetch

packages/core/src/types/conversation.ts

@@ -9,19 +9,21 @@ export interface ConversationMessageEventParams {
   id: string
   kind?: string
   metadata: Record<string, unknown>
-  subtype: string
-  text?: string
+  subtype: 'chat' | 'update'
+  text: string | null
   ts: number
   type: string
   from_address_id: string
+  user_name: string
 }
 
 export type ConversationChatMessageEventParams = Omit<
   ConversationMessageEventParams,
-  'kind' | 'hidden' | 'metadata'
+  'kind'
 > & {
   text: string
   user_name: string
+  subtype: 'chat'
 }
 
 export interface ConversationMessageEvent extends SwEvent {