Refactor e2e.rake and add demo_name validation

This commit includes multiple improvements:

E2E Testing Refactoring:
- Extract server management logic from e2e.rake into dedicated classes
- Create E2eTestRunner class to orchestrate tests across modes
- Create ServerManager class to handle server lifecycle
- Add 27 comprehensive RSpec tests for the new classes
- Reduce e2e.rake from 123 lines to 33 lines

DemoCreator Improvements:
- Add comprehensive demo_name validation with input sanitization
- Add dry-run logging for file deletion operations
- Clarify Playwright installation logic with better structure
- Remove redundant || false from prerelease flags
- Refactor completion messages into dedicated methods
- Fix Metrics/AbcSize violations through method extraction
- Add 9 new validation tests for demo_name

Install Generator:
- Add error handling for cypress_on_rails:install failures
- Provide clear guidance when generator fails

RuboCop Configuration:
- Update TargetRubyVersion from 3.0 to 3.1
- Update to use require instead of plugins (deprecated)
- Remove unused Rails cops configuration

All tests pass (200 examples, 0 failures)
All RuboCop offenses resolved

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <[email protected]>

Author: justin808

.rubocop.yml

@@ -1,12 +1,12 @@
 # RuboCop configuration for React on Rails Demos monorepo
 
-plugins:
+require:
   - rubocop-performance
 
 AllCops:
   NewCops: enable
   SuggestExtensions: false
-  TargetRubyVersion: 3.0
+  TargetRubyVersion: 3.1
   Exclude:
     - 'node_modules/**/*'
     - 'demos/**/node_modules/**/*'
@@ -40,8 +40,6 @@ Metrics/ClassLength:
 # Allow more complex methods for demo scaffolding
 Metrics/AbcSize:
   Max: 25
-  Exclude:
-    - 'lib/demo_scripts/demo_creator.rb'
 
 Metrics/CyclomaticComplexity:
   Max: 10

lib/demo_scripts/demo_creator.rb

@@ -24,6 +24,7 @@ def initialize(
       skip_playwright: false,
       typescript: false
     )
+      validate_demo_name!(demo_name)
       @demo_name = demo_name
       @scratch = scratch
       @skip_playwright = skip_playwright
@@ -49,14 +50,7 @@ def initialize(
     def create!
       run_pre_flight_checks unless @skip_pre_flight
 
-      puts ''
-      if @dry_run
-        puts '🔍 DRY RUN MODE - Commands that would be executed:'
-      else
-        puts "🚀 Creating new React on Rails demo: #{@demo_name}"
-      end
-      puts ''
-
+      print_start_message
       @creation_start_time = Time.now
 
       create_rails_app
@@ -67,19 +61,7 @@ def create!
       install_shakapacker
       install_react_on_rails
       install_demo_common_generator
-
-      # Install Playwright browsers early for non-GitHub sources
-      # (dependencies are already installed via demo_common generator)
-      install_playwright_browsers unless @skip_playwright || using_github_sources?
-
-      # Build GitHub packages and reinstall dependencies
-      # This updates package.json and runs npm install again
-      build_github_npm_packages if using_github_sources?
-
-      # Install Playwright browsers after GitHub package building
-      # (npm dependencies are now ready after rebuild)
-      install_playwright_browsers if !@skip_playwright && using_github_sources?
-
+      handle_playwright_installation
       create_readme
       cleanup_unnecessary_files
       create_metadata_file
@@ -90,6 +72,39 @@ def create!
 
     private
 
+    def print_start_message
+      puts ''
+      if @dry_run
+        puts '🔍 DRY RUN MODE - Commands that would be executed:'
+      else
+        puts "🚀 Creating new React on Rails demo: #{@demo_name}"
+      end
+      puts ''
+    end
+
+    def handle_playwright_installation
+      # Install Playwright browsers at the right time:
+      # - For npm packages: install after demo_common generator (dependencies already ready)
+      # - For GitHub sources: install after building packages (dependencies ready after rebuild)
+      return if @skip_playwright
+
+      install_playwright_browsers unless using_github_sources?
+      build_github_npm_packages if using_github_sources?
+      install_playwright_browsers if using_github_sources?
+    end
+
+    def validate_demo_name!(name)
+      raise ArgumentError, 'Demo name cannot be empty' if name.nil? || name.strip.empty?
+
+      raise ArgumentError, 'Demo name cannot contain slashes' if name.include?('/')
+
+      raise ArgumentError, 'Demo name cannot start with . or _' if name.start_with?('.', '_')
+
+      return if name.match?(/^[a-zA-Z0-9_-]+$/)
+
+      raise ArgumentError, 'Demo name can only contain alphanumeric characters, hyphens, and underscores'
+    end
+
     def run_pre_flight_checks
       PreFlightChecks.new(
         demo_dir: @demo_dir,
@@ -349,8 +364,6 @@ def install_react_on_rails
     end
 
     def cleanup_conflicting_files
-      return if @dry_run
-
       # Only remove Procfile.* files - React on Rails will overwrite shakapacker.yml with --force
       conflicting_files = [
         'Procfile.dev',
@@ -360,7 +373,11 @@ def cleanup_conflicting_files
 
       conflicting_files.each do |file|
         file_path = File.join(@demo_dir, file)
-        if File.exist?(file_path)
+        next unless File.exist?(file_path)
+
+        if @dry_run
+          puts "   [DRY RUN] Would remove conflicting file: #{file}"
+        else
           File.delete(file_path)
           puts "   Removed conflicting file: #{file}"
         end
@@ -481,8 +498,8 @@ def generate_metadata_yaml
         'options' => {
           'rails_args' => @rails_args,
           'react_on_rails_args' => @react_on_rails_args,
-          'shakapacker_prerelease' => @config.shakapacker_version&.start_with?('github:') || false,
-          'react_on_rails_prerelease' => @config.react_on_rails_version&.start_with?('github:') || false
+          'shakapacker_prerelease' => @config.shakapacker_version&.start_with?('github:'),
+          'react_on_rails_prerelease' => @config.react_on_rails_version&.start_with?('github:')
         }.compact,
         'command' => reconstruct_command,
         'ruby_version' => RUBY_VERSION,
@@ -530,45 +547,65 @@ def print_completion_message
       puts ''
       puts '=' * 80
       puts ''
-      if @dry_run
-        puts '✅ DRY RUN COMPLETE!'
-        puts ''
-        puts 'Review the commands above to see what would be executed.'
-        puts ''
-        puts 'To actually create the demo, run:'
-        puts "  bin/new-demo #{@demo_name}"
-      else
-        puts '🎉 DEMO CREATED SUCCESSFULLY!'
-        puts ''
-        puts "   Location: #{@demo_dir}"
-        puts "   Created:  #{@creation_start_time.strftime('%Y-%m-%d %H:%M:%S')}"
-        puts ''
-        puts '📋 Available Commands:'
-        puts ''
-        puts '   Start development server:'
-        puts "   $ cd #{@demo_dir} && bin/dev"
-        puts ''
-        puts '   Run E2E tests:'
-        puts "   $ cd #{@demo_dir} && npx playwright test"
-        puts ''
-        puts '   Run linting:'
-        puts "   $ cd #{@demo_dir} && bundle exec rubocop"
-        puts ''
-        puts '📚 Development Modes:'
-        puts '   • bin/dev                    - HMR (Hot Module Replacement)'
-        puts '   • bin/dev static             - Static assets mode'
-        puts '   • bin/dev prod               - Production-like mode'
-        puts ''
-        puts '🔗 Useful URLs (when server is running):'
-        puts '   • App:         http://localhost:3000'
-        puts '   • Hello World: http://localhost:3000/hello_world'
-        puts ''
-        puts "📝 Metadata: #{@demo_dir}/.demo-metadata.yml"
-        puts ''
-      end
+      @dry_run ? print_dry_run_completion : print_success_completion
       puts '=' * 80
       puts ''
     end
+
+    def print_dry_run_completion
+      puts '✅ DRY RUN COMPLETE!'
+      puts ''
+      puts 'Review the commands above to see what would be executed.'
+      puts ''
+      puts 'To actually create the demo, run:'
+      puts "  bin/new-demo #{@demo_name}"
+    end
+
+    def print_success_completion
+      puts '🎉 DEMO CREATED SUCCESSFULLY!'
+      puts ''
+      print_demo_info
+      puts ''
+      print_available_commands
+      puts ''
+      print_development_modes
+      puts ''
+      print_useful_urls
+      puts ''
+      puts "📝 Metadata: #{@demo_dir}/.demo-metadata.yml"
+      puts ''
+    end
+
+    def print_demo_info
+      puts "   Location: #{@demo_dir}"
+      puts "   Created:  #{@creation_start_time.strftime('%Y-%m-%d %H:%M:%S')}"
+    end
+
+    def print_available_commands
+      puts '📋 Available Commands:'
+      puts ''
+      puts '   Start development server:'
+      puts "   $ cd #{@demo_dir} && bin/dev"
+      puts ''
+      puts '   Run E2E tests:'
+      puts "   $ cd #{@demo_dir} && npx playwright test"
+      puts ''
+      puts '   Run linting:'
+      puts "   $ cd #{@demo_dir} && bundle exec rubocop"
+    end
+
+    def print_development_modes
+      puts '📚 Development Modes:'
+      puts '   • bin/dev                    - HMR (Hot Module Replacement)'
+      puts '   • bin/dev static             - Static assets mode'
+      puts '   • bin/dev prod               - Production-like mode'
+    end
+
+    def print_useful_urls
+      puts '🔗 Useful URLs (when server is running):'
+      puts '   • App:         http://localhost:3000'
+      puts '   • Hello World: http://localhost:3000/hello_world'
+    end
   end
   # rubocop:enable Metrics/ClassLength
 end

packages/shakacode_demo_common/config/rubocop.yml

@@ -2,7 +2,6 @@
 # Based on Rails Omakase with adjustments for React on Rails
 
 require:
-  - rubocop-rails
   - rubocop-performance
 
 AllCops:
@@ -58,18 +57,6 @@ Metrics/BlockLength:
 Metrics/ClassLength:
   Max: 200
 
-# Rails specific
-Rails/ApplicationRecord:
-  Enabled: true
-
-Rails/I18nLocaleTexts:
-  Enabled: false
-
 # Performance
 Performance/RedundantMerge:
   Enabled: true
-
-# React on Rails specific patterns
-Rails/OutputSafety:
-  Exclude:
-    - 'app/helpers/react_on_rails_helper.rb'

packages/shakacode_demo_common/lib/generators/shakacode_demo_common/install/install_generator.rb

@@ -116,7 +116,15 @@ def add_to_gitignore
 
       def install_cypress_on_rails_with_playwright
         say 'Installing cypress-on-rails with Playwright framework'
-        run 'bin/rails generate cypress_on_rails:install --framework playwright --install_folder e2e'
+        success = run 'bin/rails generate cypress_on_rails:install --framework playwright --install_folder e2e'
+
+        unless success
+          say 'Failed to install cypress-on-rails generator', :red
+          command = 'bin/rails generate cypress_on_rails:install --framework playwright --install_folder e2e'
+          say "You may need to run: #{command}", :yellow
+        end
+
+        success
       end
 
       def create_playwright_test