Add prerelease version support and Playwright testing (#12)

Author: justin808

.gitignore

@@ -45,6 +45,12 @@ vendor/bundle/
 /demos/*/coverage/
 /demos/*/test/reports/
 spec/examples.txt
+/test-results/
+/playwright-report/
+
+# Generated demo config files
+/packages/shakacode_demo_common/config/.eslintrc.js
+/packages/shakacode_demo_common/config/.rubocop.yml
 
 # Database
 /demos/*/db/*.sqlite3

bin/new-demo

@@ -10,7 +10,9 @@ options = {
   react_on_rails_version: nil,
   rails_args: [],
   react_on_rails_args: [],
-  dry_run: false
+  dry_run: false,
+  shakapacker_prerelease: false,
+  react_on_rails_prerelease: false
 }
 
 parser = OptionParser.new do |opts|
@@ -21,6 +23,11 @@ parser = OptionParser.new do |opts|
   opts.separator '  Shakapacker, and React on Rails pre-configured. Uses version defaults'
   opts.separator '  from .new-demo-versions unless overridden.'
   opts.separator ''
+  opts.separator '  Automatically installs:'
+  opts.separator '    - Playwright E2E testing (run with: npx playwright test)'
+  opts.separator '    - Linting and code quality tools'
+  opts.separator '    - Git hooks via Lefthook'
+  opts.separator ''
   opts.separator 'Example: bin/new-demo react_on_rails-demo-v16-typescript-setup'
   opts.separator ''
   opts.separator 'Options:'
@@ -46,15 +53,42 @@ parser = OptionParser.new do |opts|
     options[:react_on_rails_args] = args.split(',').map(&:strip)
   end
 
+  opts.on('--shakapacker-prerelease', 'Use latest prerelease (beta/rc) version for Shakapacker') do
+    options[:shakapacker_prerelease] = true
+  end
+
+  opts.on('--react-on-rails-prerelease', 'Use latest prerelease (beta/rc) version for React on Rails') do
+    options[:react_on_rails_prerelease] = true
+  end
+
+  opts.on('--prerelease', 'Use latest prerelease (beta/rc) versions for both gems') do
+    options[:shakapacker_prerelease] = true
+    options[:react_on_rails_prerelease] = true
+  end
+
   opts.on('-h', '--help', 'Show this help message') do
     puts opts
     puts ''
     puts 'Examples:'
+    puts '  # Basic demo with defaults'
+    puts '  bin/new-demo my-demo'
+    puts ''
+    puts '  # Use prerelease versions'
+    puts '  bin/new-demo my-demo --prerelease'
+    puts '  bin/new-demo my-demo --shakapacker-prerelease'
+    puts '  bin/new-demo my-demo --react-on-rails-prerelease'
+    puts ''
+    puts '  # Use GitHub branches'
+    puts '  bin/new-demo my-demo --shakapacker-version="github:shakacode/shakapacker@my-branch"'
+    puts '  bin/new-demo my-demo --react-on-rails-version="github:shakacode/react_on_rails@fix-hmr"'
+    puts ''
+    puts '  # Customize Rails and React on Rails setup'
     puts '  bin/new-demo my-demo --rails-args="--skip-test,--api"'
     puts '  bin/new-demo my-demo --react-on-rails-args="--redux,--node"'
     puts '  bin/new-demo my-demo --rails-args="--skip-test" --react-on-rails-args="--redux"'
-    puts '  bin/new-demo my-demo --shakapacker-version="github:shakacode/shakapacker@my-branch"'
-    puts '  bin/new-demo my-demo --react-on-rails-version="github:shakacode/react_on_rails@fix-hmr"'
+    puts ''
+    puts 'After creation, run E2E tests with:'
+    puts '  cd demos/my-demo && npx playwright test'
     exit
   end
 end

lib/demo_scripts/config.rb

@@ -9,17 +9,41 @@ class Config
 
     attr_reader :shakapacker_version, :react_on_rails_version, :rails_version
 
-    def initialize(config_file: nil, shakapacker_version: nil, react_on_rails_version: nil, rails_version: nil)
+    def initialize(config_file: nil, shakapacker_version: nil, react_on_rails_version: nil, rails_version: nil,
+                   shakapacker_prerelease: false, react_on_rails_prerelease: false)
       @config_file = config_file || File.join(Dir.pwd, '.new-demo-versions')
       load_config if File.exist?(@config_file)
 
-      @shakapacker_version = shakapacker_version || @shakapacker_version || DEFAULT_SHAKAPACKER_VERSION
-      @react_on_rails_version = react_on_rails_version || @react_on_rails_version || DEFAULT_REACT_ON_RAILS_VERSION
+      @shakapacker_version = resolve_version('shakapacker', shakapacker_version, shakapacker_prerelease)
+      @react_on_rails_version = resolve_version('react_on_rails', react_on_rails_version, react_on_rails_prerelease)
       @rails_version = rails_version || @rails_version || DEFAULT_RAILS_VERSION
     end
 
     private
 
+    def resolve_version(gem_name, custom_version, use_prerelease)
+      return custom_version if custom_version
+
+      if use_prerelease
+        prerelease = fetch_latest_prerelease(gem_name)
+        # Prefer config file version over default if prerelease fetch fails
+        prerelease || instance_variable_get("@#{gem_name}_version") || default_version_for(gem_name)
+      else
+        instance_variable_get("@#{gem_name}_version") || default_version_for(gem_name)
+      end
+    end
+
+    def default_version_for(gem_name)
+      case gem_name
+      when 'shakapacker'
+        DEFAULT_SHAKAPACKER_VERSION
+      when 'react_on_rails'
+        DEFAULT_REACT_ON_RAILS_VERSION
+      else
+        raise ArgumentError, "Unknown gem: #{gem_name}"
+      end
+    end
+
     def load_config
       File.readlines(@config_file, encoding: 'UTF-8').each do |line|
         next if line.strip.empty? || line.strip.start_with?('#')
@@ -34,5 +58,51 @@ def load_config
         end
       end
     end
+
+    def fetch_latest_prerelease(gem_name)
+      require 'open3'
+
+      # Use array syntax to prevent command injection
+      stdout, stderr, status = Open3.capture3('gem', 'search', '-ra', "^#{gem_name}$")
+
+      unless status.success?
+        warn "Warning: Failed to fetch prerelease version for #{gem_name}: #{stderr}"
+        return nil
+      end
+
+      versions = parse_gem_versions(stdout)
+      prerelease = find_latest_prerelease(versions)
+
+      if prerelease
+        puts "   Found prerelease version for #{gem_name}: #{prerelease}"
+        prerelease
+      else
+        warn "Warning: No prerelease version found for #{gem_name}"
+        nil
+      end
+    rescue StandardError => e
+      warn "Warning: Error fetching prerelease version for #{gem_name}: #{e.message}"
+      nil
+    end
+
+    def parse_gem_versions(stdout)
+      # Expected format: "gem_name (version1, version2, ...)"
+      match = stdout.match(/\(([^)]+)\)/)
+      return [] unless match
+
+      match[1].split(',').map(&:strip)
+    end
+
+    def find_latest_prerelease(versions)
+      # Strict semver prerelease pattern: must have major.minor.patch followed by -beta.N or -rc.N
+      # This ensures we only match valid semver prereleases, not arbitrary strings
+      prerelease_versions = versions.grep(/^\d+\.\d+\.\d+[.-](beta|rc)(\.\d+)?$/i)
+
+      return nil if prerelease_versions.empty?
+
+      # Sort by version to get the latest (versions are already sorted by rubygems, but be explicit)
+      # rubygems returns versions in descending order, so first match is latest
+      prerelease_versions.first
+    end
   end
 end

lib/demo_scripts/demo_creator.rb

@@ -17,13 +17,17 @@ def initialize(
       rails_args: [],
       react_on_rails_args: [],
       dry_run: false,
-      skip_pre_flight: false
+      skip_pre_flight: false,
+      shakapacker_prerelease: false,
+      react_on_rails_prerelease: false
     )
       @demo_name = demo_name
       @demo_dir = File.join('demos', demo_name)
       @config = Config.new(
         shakapacker_version: shakapacker_version,
-        react_on_rails_version: react_on_rails_version
+        react_on_rails_version: react_on_rails_version,
+        shakapacker_prerelease: shakapacker_prerelease,
+        react_on_rails_prerelease: react_on_rails_prerelease
       )
       @rails_args = rails_args || []
       @react_on_rails_args = react_on_rails_args || []
@@ -50,6 +54,7 @@ def create!
       create_symlinks
       install_shakapacker
       install_react_on_rails
+      install_demo_common_generator
       build_github_npm_packages if using_github_sources?
       create_readme
       cleanup_unnecessary_files
@@ -312,6 +317,12 @@ def install_react_on_rails
       )
     end
 
+    def install_demo_common_generator
+      puts ''
+      puts '📦 Installing demo common tools (Playwright, linting, git hooks)...'
+      @runner.run!('bin/rails generate shakacode_demo_common:install', dir: @demo_dir)
+    end
+
     def create_readme
       puts ''
       puts '📝 Creating README...'

packages/shakacode_demo_common/lib/generators/shakacode_demo_common/install/install_generator.rb

@@ -98,24 +98,66 @@ def add_to_gitignore
           coverage/
           .nyc_output/
 
+          # Playwright
+          /playwright-report/
+          /test-results/
+
           # IDE
           .vscode/
           .idea/
         IGNORE
       end
 
+      def add_playwright_gem
+        say 'Adding cypress-playwright-on-rails gem'
+        gem 'cypress-playwright-on-rails', group: %i[development test]
+        run 'bundle install'
+      end
+
+      def install_playwright
+        say 'Installing Playwright'
+        run 'bin/rails generate cypress_playwright_on_rails:install --playwright'
+      end
+
+      def create_playwright_test
+        say 'Creating basic Playwright test for /hello_world'
+        create_file 'spec/e2e/hello_world.spec.js', <<~JS
+          // @ts-check
+          const { test, expect } = require('@playwright/test');
+
+          test.describe('Hello World Page', () => {
+            test('should load successfully', async ({ page }) => {
+              await page.goto('/hello_world');
+              await expect(page).toHaveTitle(/React on Rails/);
+            });
+
+            test('should render React component', async ({ page }) => {
+              await page.goto('/hello_world');
+              // Wait for React to hydrate
+              await page.waitForLoadState('networkidle');
+
+              // Check for common React on Rails elements
+              const content = await page.textContent('body');
+              expect(content).toBeTruthy();
+            });
+          });
+        JS
+      end
+
       def display_post_install
         say "\n✅ React on Rails Demo Common installed successfully!", :green
         say "\nNext steps:", :yellow
         say "  1. Run 'bundle exec rubocop' to check Ruby code style"
         say "  2. Run 'npm run lint' to check JavaScript code style"
         say "  3. Run 'bundle exec rake demo_common:all' to run all checks"
         say '  4. Commit hooks are now active via Lefthook'
+        say "  5. Run 'npx playwright test' to run E2E tests"
         say "\nCustomize configurations in:", :blue
         say '  - .rubocop.yml'
         say '  - .eslintrc.js'
         say '  - .prettierrc.js'
         say '  - lefthook.yml'
+        say '  - playwright.config.js'
       end
 
       private