fix: ignore eks-managed lifecycle hooks

Author: sebltm

pkg/cloud/services/eks/nodegroup.go

@@ -34,14 +34,18 @@ import (
 	expinfrav1 "sigs.k8s.io/cluster-api-provider-aws/v2/exp/api/v1beta2"
 	"sigs.k8s.io/cluster-api-provider-aws/v2/pkg/cloud/awserrors"
 	"sigs.k8s.io/cluster-api-provider-aws/v2/pkg/cloud/converters"
-	"sigs.k8s.io/cluster-api-provider-aws/v2/pkg/cloud/services"
 	"sigs.k8s.io/cluster-api-provider-aws/v2/pkg/cloud/services/wait"
 	"sigs.k8s.io/cluster-api-provider-aws/v2/pkg/record"
 	clusterv1 "sigs.k8s.io/cluster-api/api/v1beta1"
 	"sigs.k8s.io/cluster-api/util/annotations"
 	"sigs.k8s.io/cluster-api/util/conditions"
 )
 
+var IgnoreLifecycleHooks = map[string]bool{
+	"Launch-LC-Hook":    true,
+	"Terminate-LC-Hook": true,
+}
+
 func (s *NodegroupService) describeNodegroup() (*eks.Nodegroup, error) {
 	eksClusterName := s.scope.KubernetesClusterName()
 	nodegroupName := s.scope.NodegroupName()
@@ -152,7 +156,7 @@ func (s *NodegroupService) remoteAccess() (*eks.RemoteAccessConfig, error) {
 	// SourceSecurityGroups is validated to be empty if PublicAccess is true
 	// but just in case we use an empty list to take advantage of the documented
 	// API behavior
-	var sSGs = []string{}
+	sSGs := []string{}
 
 	if !pool.RemoteAccess.Public {
 		sSGs = pool.RemoteAccess.SourceSecurityGroups
@@ -573,7 +577,7 @@ func (s *NodegroupService) reconcileNodegroup(ctx context.Context) error {
 		return errors.Wrapf(err, "failed to reconcile asg tags")
 	}
 
-	if err := s.reconcileLifecycleHooks(s.ASGService); err != nil {
+	if err := s.reconcileLifecycleHooks(ng); err != nil {
 		return errors.Wrapf(err, "failed to reconcile lifecyle hooks")
 	}
 
@@ -653,21 +657,29 @@ func (s *NodegroupService) waitForNodegroupActive() (*eks.Nodegroup, error) {
 }
 
 // ReconcileLifecycleHooks periodically reconciles a lifecycle hook for the ASG.
-func (s *NodegroupService) reconcileLifecycleHooks(asgsvc services.ASGInterface) error {
+func (s *NodegroupService) reconcileLifecycleHooks(ng *eks.Nodegroup) error {
+	asg, err := s.describeASGs(ng)
+	if err != nil {
+		return err
+	}
+
 	lifecyleHooks := s.scope.GetLifecycleHooks()
 	for i := range lifecyleHooks {
-		if err := s.reconcileLifecycleHook(&lifecyleHooks[i], asgsvc); err != nil {
+		if err := s.reconcileLifecycleHook(*asg.AutoScalingGroupName, &lifecyleHooks[i]); err != nil {
 			return err
 		}
 	}
 
 	// Get a list of lifecycle hooks that are registered with the ASG but not defined in the MachinePool and delete them.
-	hooks, err := asgsvc.DescribeLifecycleHooks(s.scope.NodegroupName())
+	hooks, err := s.ASGService.DescribeLifecycleHooks(*asg.AutoScalingGroupName)
 	if err != nil {
 		return err
 	}
 	for _, hook := range hooks {
 		found := false
+		if IgnoreLifecycleHooks[hook.Name] {
+			continue
+		}
 		for _, definedHook := range lifecyleHooks {
 			if hook.Name == definedHook.Name {
 				found = true
@@ -676,7 +688,7 @@ func (s *NodegroupService) reconcileLifecycleHooks(asgsvc services.ASGInterface)
 		}
 		if !found {
 			s.scope.Info("Deleting extraneous lifecycle hook", "hook", hook.Name)
-			if err := asgsvc.DeleteLifecycleHook(s.scope.NodegroupName(), hook); err != nil {
+			if err := s.ASGService.DeleteLifecycleHook(*asg.AutoScalingGroupName, hook); err != nil {
 				conditions.MarkFalse(s.scope.GetMachinePool(), expinfrav1.LifecycleHookReadyCondition, expinfrav1.LifecycleHookDeletionFailedReason, clusterv1.ConditionSeverityError, err.Error())
 				return err
 			}
@@ -686,29 +698,34 @@ func (s *NodegroupService) reconcileLifecycleHooks(asgsvc services.ASGInterface)
 	return nil
 }
 
-func (s *NodegroupService) reconcileLifecycleHook(hook *expinfrav1.AWSLifecycleHook, asgsvc services.ASGInterface) error {
+func (s *NodegroupService) reconcileLifecycleHook(asgName string, hook *expinfrav1.AWSLifecycleHook) error {
 	s.scope.Info("Checking for existing lifecycle hook")
-	existingHook, err := asgsvc.DescribeLifecycleHook(s.scope.NodegroupName(), hook)
+	// Ignore hooks that are not managed by the controller
+	if ignore, ok := IgnoreLifecycleHooks[hook.Name]; ok && ignore {
+		return nil
+	}
+
+	existingHook, err := s.ASGService.DescribeLifecycleHook(asgName, hook)
 	if err != nil {
 		conditions.MarkUnknown(s.scope.GetMachinePool(), expinfrav1.LifecycleHookReadyCondition, expinfrav1.LifecycleHookNotFoundReason, err.Error())
 		return err
 	}
 
 	if existingHook == nil {
 		s.scope.Info("Creating lifecycle hook")
-		if err := asgsvc.CreateLifecycleHook(s.scope.NodegroupName(), hook); err != nil {
+		if err := s.ASGService.CreateLifecycleHook(asgName, hook); err != nil {
 			conditions.MarkFalse(s.scope.GetMachinePool(), expinfrav1.LifecycleHookReadyCondition, expinfrav1.LifecycleHookCreationFailedReason, clusterv1.ConditionSeverityError, err.Error())
 			return err
 		}
 		return nil
 	}
 
 	// If the lifecycle hook exists, we need to check if it's up to date
-	needsUpdate := asgsvc.LifecycleHookNeedsUpdate(existingHook, hook)
+	needsUpdate := s.ASGService.LifecycleHookNeedsUpdate(existingHook, hook)
 
 	if needsUpdate {
 		s.scope.Info("Updating lifecycle hook")
-		if err := asgsvc.UpdateLifecycleHook(s.scope.NodegroupName(), hook); err != nil {
+		if err := s.ASGService.UpdateLifecycleHook(asgName, hook); err != nil {
 			conditions.MarkFalse(s.scope.GetMachinePool(), expinfrav1.LifecycleHookReadyCondition, expinfrav1.LifecycleHookUpdateFailedReason, clusterv1.ConditionSeverityError, err.Error())
 			return err
 		}