Motivated by #4471, do not even try to add non-public methods as test methods

Author: sebastianbergmann

src/Framework/TestSuite.php

@@ -192,6 +192,10 @@ public function __construct($theClass = '', string $name = '')
                 continue;
             }
 
+            if (!TestUtil::isTestMethod($method)) {
+                continue;
+            }
+
             $this->addTestMethod($theClass, $method);
         }
 
@@ -744,26 +748,8 @@ protected function createResult(): TestResult
      */
     protected function addTestMethod(\ReflectionClass $class, \ReflectionMethod $method): void
     {
-        if (!TestUtil::isTestMethod($method)) {
-            return;
-        }
-
         $methodName = $method->getName();
 
-        if (!$method->isPublic()) {
-            $this->addTest(
-                new WarningTestCase(
-                    \sprintf(
-                        'Test method "%s" in test class "%s" is not public.',
-                        $methodName,
-                        $class->getName()
-                    )
-                )
-            );
-
-            return;
-        }
-
         $test = (new TestBuilder)->build($class, $methodName);
 
         if ($test instanceof TestCase || $test instanceof DataProviderTestSuite) {

src/Util/Test.php

@@ -519,6 +519,10 @@ public static function getHookMethods(string $className): array
 
     public static function isTestMethod(\ReflectionMethod $method): bool
     {
+        if (!$method->isPublic()) {
+            return false;
+        }
+
         if (\strpos($method->getName(), 'test') === 0) {
             return true;
         }

tests/unit/Framework/TestSuiteTest.php

@@ -76,7 +76,7 @@ public function testNotPublicTestCase(): void
     {
         $suite = new TestSuite(\NotPublicTestCase::class);
 
-        $this->assertCount(2, $suite);
+        $this->assertCount(1, $suite);
     }
 
     public function testNotVoidTestCase(): void