Skip to content

Conversation

@adroitwhiz
Copy link
Contributor

Proposed Changes

This PR removes the u_fudge uniform from the GLSL code and all renderer code that sets uniforms.

Reason for Changes

u_fudge was first used in the testing playground as a way to debug effects. By hooking it up to a slider, it could control an arbitrary shader component--this was useful for testing the shaders.

Now, the "fudge" slider in the playground does not control u_fudge, but can instead set many other properties of the playground's test drawable, including every effect.

Every call to gl.uniform[*] adds a small performance cost, so we want to avoid setting unnecessary uniforms.

@thisandagain
Copy link
Contributor

/cc @cwillisf @kchadha @mzgoddard

@cwillisf cwillisf modified the milestones: August 2019, September 2019 Sep 5, 2019
Copy link
Contributor

@cwillisf cwillisf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😄

@cwillisf cwillisf modified the milestones: September 2019, October 2019 Oct 1, 2019
@cwillisf cwillisf merged commit 13b9ed7 into scratchfoundation:develop Oct 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants