feat(coreutils): update for newer GNU coreutils #1457
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Failing test on Fedora looks unrelated. Running on Fedora locally it's fine. Ran like: |
pixelb
changed the title
pixelb
changed the title
Yeah this is a known issue, see #1435 |
|
If you rebase on main the test should succeed now |
Adjust for changes in GNU coreutils. Valid as of coreutils 9.5 (Mar 2024). Add completions for: base32, basenc, cksum, comm, numfmt, readlink, realpath, shred, shuf, stat, sync Adjust completions for: chgrp: add --from dd: remove deprecated *_bytes flags
scop
requested changes
Oct 12, 2025
| [[ $w == -@(R|-recursive) ]] && opts="-H -L -P" && break | ||
| done | ||
| _comp_compgen -- -W '-c -h -f -R -v --changes --dereference | ||
| _comp_compgen -- -W '-c -h -f -R -v --changes --dereference --from |
There was a problem hiding this comment.
Just a note, we'd be better off parsing instead of hardcoding, but that's something for another PR.
scop
approved these changes
Oct 19, 2025
|
Added basic tests and missing cksum symlink setup, merging with that. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adjust for changes in GNU coreutils.
Valid as of coreutils 9.5 (Mar 2024).
Add completions for:
base32, basenc, cksum, comm, numfmt, readlink, realpath,
shred, shuf, stat, sync
Adjust completions for:
chgrp: add --from
dd: remove deprecated *_bytes flags