Skip to content

Conversation

akinomyoga
Copy link
Collaborator

See the commit message.

#1404 (comment)

I don't see a problem adding more of them. crx would fit in well if it's a zip, we have xpi already which is corresponding thing for Firefox.

#1404 (comment)

But re these, would be great to provide URLs to some sample files with which reviewers could verify that they work with these tools.

I've included the reference URL in the commit message as usual, but it might be harder to track the changes later because many extensions are included in a single line where git blame isn't useful to identify a commit that added a specific filename extension. Maybe we should include the reference information directly in the code comment inside the source code bash_completion. What do you think?

@akinomyoga akinomyoga force-pushed the zip-crx branch 2 times, most recently from ddfe7ae to 296c462 Compare August 3, 2025 07:48
@akinomyoga
Copy link
Collaborator Author

akinomyoga commented Aug 3, 2025

The following commits have added filename extensions for unzip and zipinfo.

@akinomyoga akinomyoga changed the title feat(zip,unzip): generate *.crx for Google Chrome Extension's ZIP archives feat(unzip,zipinfo): generate *.crx for Google Chrome Extension's ZIP archives Aug 3, 2025
@scop
Copy link
Owner

scop commented Aug 7, 2025

Agree that git blame isn't too useful for these lines, but I think it's good enough if we clearly note each extension in the commit message. With the preceding dot it should be searchable enough from git log.

Copy link
Owner

@scop scop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, needs conflict resolution. Thanks!

@akinomyoga akinomyoga merged commit 1631952 into scop:main Aug 8, 2025
7 checks passed
@akinomyoga akinomyoga deleted the zip-crx branch August 8, 2025 03:40
@akinomyoga
Copy link
Collaborator Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants