refactor(_comp_dequote): apply suggestions from code review

Co-authored-by: Ville Skyttä <[email protected]>

Author: akinomyoga

bash_completion

@@ -176,14 +176,14 @@ quote_readline()
 _comp_dequote__initialize()
 {
     unset -f "$FUNCNAME"
-    local param='\$([_a-zA-Z][_a-zA-Z0-9]*|[-*@#?$!0-9_])|\$\{[!#]?([_a-zA-Z][_a-zA-Z0-9]*(\[([0-9]+|[*@])\])?|[-*@#?$!0-9_])\}'
-    local quote='\\.|'\''[^'\'']*'\''|\$?"([^\"$`!]|'$param'|\\.)*"|\$'\''([^\'\'']|\\.)*'\'''
-    _comp_dequote__regex_safe_word='^([^\'\''"$`;&|<>()!]|'$quote'|'$param')*$'
+    local regex_param='\$([_a-zA-Z][_a-zA-Z0-9]*|[-*@#?$!0-9_])|\$\{[!#]?([_a-zA-Z][_a-zA-Z0-9]*(\[([0-9]+|[*@])\])?|[-*@#?$!0-9_])\}'
+    local regex_quoted='\\.|'\''[^'\'']*'\''|\$?"([^\"$`!]|'$regex_param'|\\.)*"|\$'\''([^\'\'']|\\.)*'\'''
+    _comp_dequote__regex_safe_word='^([^\'\''"$`;&|<>()!]|'$regex_quoted'|'$regex_param')*$'
 }
 _comp_dequote__initialize
 
 # This function expands a word using `eval` in a safe way.  This function can
-# be typically used to get the expqanded value of `${word[i]}` as
+# be typically used to get the expanded value of `${word[i]}` as
 # `_comp_dequote "${word[i]}"`.  When the word contains unquoted shell special
 # characters, command substitutions, and other unsafe strings, the function
 # call fails before applying `eval`.  Otherwise, `eval` is applied to the
@@ -240,9 +240,9 @@ dequote()
 {
     local ret
     _comp_dequote "$1"
-    local ext=$?
+    local rc=$?
     printf %s "$ret"
-    return $ext
+    return $rc
 }
 
 # Unset the given variables across a scope boundary. Useful for unshadowing