[updater] Fix hardcoded App-ID for Managed Preferences

This is the name of the preferences plist used by the updater to apply
on-prem distributed enterprise policies on MacOS. This being hardcoded
means that updater embedders might accidentally apply global settings
meant for Chrome Updater to updaters for other software. Use
`branding.gni` instead.

Fixed: 372361350
Change-Id: I2de9b29ec2086804750cbbb2def17779022974c3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5962279
Reviewed-by: Joshua Pawlicki <[email protected]>
Reviewed-by: Sorin Jianu <[email protected]>
Commit-Queue: Joshua Pawlicki <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1389012}

Author: Aaron Tagliaboschi

chrome/updater/policy/mac/managed_preference_policy_manager.mm

@@ -18,10 +18,11 @@
 #include "chrome/updater/constants.h"
 #include "chrome/updater/policy/mac/managed_preference_policy_manager_impl.h"
 #include "chrome/updater/policy/manager.h"
+#include "chrome/updater/updater_branding.h"
 
 namespace {
 NSString* const kManagedPreferencesUpdatePolicies = @"updatePolicies";
-NSString* const kKeystoneSharedPreferenceSuite = @"com.google.Keystone";
+NSString* const kKeystoneSharedPreferenceSuite = @LEGACY_GOOGLE_UPDATE_APPID;
 }  // namespace
 
 namespace updater {

chrome/updater/test/integration_tests_mac.mm

@@ -337,7 +337,7 @@ void ExpectLegacyUpdaterMigrated(UpdaterScope scope) {
 
   // Keystone should not be migrated.
   EXPECT_FALSE(
-      persisted_data->GetProductVersion("com.google.keystone").IsValid());
+      persisted_data->GetProductVersion(LEGACY_GOOGLE_UPDATE_APPID).IsValid());
 
   // Uninstalled app should be migrated.
   EXPECT_TRUE(
@@ -410,7 +410,7 @@ void UninstallApp(UpdaterScope scope, const std::string& app_id) {
 }
 
 void SetPlatformPolicies(const base::Value::Dict& values) {
-  const CFStringRef domain = CFSTR("com.google.Keystone");
+  const CFStringRef domain = CFSTR(LEGACY_GOOGLE_UPDATE_APPID);
 
   // Synchronize just to be safe. Ignore spurious errors if the domain
   // does not yet exist.
@@ -436,7 +436,7 @@ void SetPlatformPolicies(const base::Value::Dict& values) {
     NSURL* const managed_preferences_url = base::apple::FilePathToNSURL(
         GetLibraryFolderPath(UpdaterScope::kSystem)
             ->AppendASCII("Managed Preferences")
-            .AppendASCII("com.google.Keystone.plist"));
+            .AppendASCII(LEGACY_GOOGLE_UPDATE_APPID ".plist"));
     ASSERT_TRUE([[NSDictionary dictionaryWithObject:all_policies
                                              forKey:@"updatePolicies"]
         writeToURL:managed_preferences_url