Skip to content

Add "all" as a valid value for strategy in domain_record in http_service mode #2137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 27, 2023
Merged

Add "all" as a valid value for strategy in domain_record in http_service mode #2137

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fddd2cd
Add "all" as a valid value for strategy in domain_record in http_serv…
pablo-ruth Sep 27, 2023
3659f4d
update doc
pablo-ruth Sep 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/resources/domain_record.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -211,7 +211,7 @@ The following arguments are supported:
- `must_contain` - (Required) Text to search
- `url` - (Required) URL to match the `must_contain` text to validate an IP
- `user_agent` - (Optional) User-agent used when checking the URL
- `strategy` - (Required) Strategy to return an IP from the IPs list. Can be `random` or `hashed`
- `strategy` - (Required) Strategy to return an IP from the IPs list. Can be `random`, `hashed` or `all`


- `view` - (Optional) The answer to a DNS request is based on the client’s (resolver) subnet. *(Can be more than 1)* [Documentation and usage example](https://www.scaleway.com/en/docs/network/domains-and-dns/how-to/manage-dns-records/#views-records)
Expand Down
1 change: 1 addition & 0 deletions scaleway/resource_domain_record.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,6 +188,7 @@ func resourceScalewayDomainRecord() *schema.Resource {
ValidateFunc: validation.StringInSlice([]string{
domain.RecordHTTPServiceConfigStrategyRandom.String(),
domain.RecordHTTPServiceConfigStrategyHashed.String(),
domain.RecordHTTPServiceConfigStrategyAll.String(),
}, false),
},
},
Expand Down