Skip to content

Commit 30ede40

Browse files
author
Awjin Ahn
authored
Fix extending selectors across multiple modules. (#1298)
* Fix extending selectors across multiple modules. Allows more than one module to extend the same upstream selector that, in turn, extends a selector from its upstream module. Properly skips creating an extra extension that was being counted as unresolved when evaluating @extends. See sass/sass-spec#1635 Fixes #1295
1 parent 295a116 commit 30ede40

File tree

3 files changed

+8
-2
lines changed

3 files changed

+8
-2
lines changed

CHANGELOG.md

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,9 @@
1+
## 1.32.12
2+
3+
* Fix a bug that disallowed more than one module from extending the same
4+
selector from a module if that selector itself extended a selector from
5+
another upstream module.
6+
17
## 1.32.11
28

39
* Fix a bug where bogus indented syntax errors were reported for lines that

lib/src/extend/extension_store.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -328,7 +328,7 @@ class ExtensionStore {
328328
}
329329

330330
var containsExtension = selectors.first == extension.extender.selector;
331-
var first = false;
331+
var first = true;
332332
for (var complex in selectors) {
333333
// If the output contains the original complex selector, there's no
334334
// need to recreate it.

pubspec.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
name: sass
2-
version: 1.32.11
2+
version: 1.32.12
33
description: A Sass implementation in Dart.
44
author: Sass Team
55
homepage: https://github.com/sass/dart-sass

0 commit comments

Comments
 (0)