Skip to content

Commit 926b887

Browse files
authored
Cleanup regressions (#132)
* Fix error checking for windows triple slash * Pylint: Add back our module level doc strings, even if slightly redundant currently * Pylint: Inheritting from object isn't needed in python 3 * Pylint: Opt in to our slower running linting tests. * Once we have full linting coverage this can be its own stage but for now run the pytest hack with list of covered files.
1 parent 33d3d3b commit 926b887

File tree

15 files changed

+22
-12
lines changed

15 files changed

+22
-12
lines changed

.github/workflows/regression-tests.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ jobs:
4141
# flake8 . --count --exit-zero --max-complexity=10 --max-line-length=127 --statistics
4242
- name: Run tests
4343
run: |
44-
coverage run --source pyttb -m pytest tests/
44+
coverage run --source pyttb -m pytest tests/ --packaging
4545
coverage report
4646
- name: Upload coverage to Coveralls
4747
uses: coverallsapp/github-action@v2

pyttb/hosvd.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
"""Higher Order SVD Implementation"""
12
# Copyright 2022 National Technology & Engineering Solutions of Sandia,
23
# LLC (NTESS). Under the terms of Contract DE-NA0003525 with NTESS, the
34
# U.S. Government retains certain rights in this software.

pyttb/khatrirao.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
"""Khatri-Rao Product Implementation"""
12
# Copyright 2022 National Technology & Engineering Solutions of Sandia,
23
# LLC (NTESS). Under the terms of Contract DE-NA0003525 with NTESS, the
34
# U.S. Government retains certain rights in this software.

pyttb/ktensor.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
"""Classes and functions for working with Kruskal tensors."""
12
# Copyright 2022 National Technology & Engineering Solutions of Sandia,
23
# LLC (NTESS). Under the terms of Contract DE-NA0003525 with NTESS, the
34
# U.S. Government retains certain rights in this software.

pyttb/pyttb_utils.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
"""PYTTB shared utilities across tensor types"""
12
# Copyright 2022 National Technology & Engineering Solutions of Sandia,
23
# LLC (NTESS). Under the terms of Contract DE-NA0003525 with NTESS, the
34
# U.S. Government retains certain rights in this software.

pyttb/sptensor.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
"""Sparse Tensor Implementation"""
12
# Copyright 2022 National Technology & Engineering Solutions of Sandia,
23
# LLC (NTESS). Under the terms of Contract DE-NA0003525 with NTESS, the
34
# U.S. Government retains certain rights in this software.
@@ -89,7 +90,7 @@ def tt_from_sparse_matrix(
8990
return sptensorInstance
9091

9192

92-
class sptensor(object):
93+
class sptensor:
9394
"""
9495
SPTENSOR Class for sparse tensors.
9596
"""

pyttb/sptensor3.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
import pyttb as ttb
66

77

8-
class sptensor3(object):
8+
class sptensor3:
99
"""
1010
SPTENSOR3 a sparse tensor variant.
1111

pyttb/sumtensor.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
import pyttb as ttb
66

77

8-
class sumtensor(object):
8+
class sumtensor:
99
"""
1010
SUMTENSOR Class for implicit sum of other tensors.
1111

pyttb/symktensor.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
from .pyttb_utils import *
1010

1111

12-
class symktensor(object):
12+
class symktensor:
1313
"""
1414
SYMKTENSOR Class for symmetric Kruskal tensors (decomposed).
1515

pyttb/symtensor.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
import pyttb as ttb
66

77

8-
class symtensor(object):
8+
class symtensor:
99
"""
1010
SYMTENSOR Class for storing only unique entries of symmetric tensor.
1111

0 commit comments

Comments
 (0)