fix(service): change default service name

Docker daemon service name in official Docker packages
is 'docker' but formula uses 'dockerd'. Due to these differences
docker service won't start after installation.

Fix documentation link in systemd service

Docker daemon binary in official Docker archive distribution
is always 'dockerd' no reason to substitute service name

'null' from yaml is rendering as 'None' by Jinja therefore,
systemd displays a warning in the log, replace with empty string
to prevent this issue

BREAKING CHANGE: due changes in default service name, on systems
where 'archive' installation method is used, duplicate service
will be created. This can be avoided by updating pillar with
'docker:pkg:docker:service:name: dockerd'. Due fact that 'archive'
method is default this change may affect a large number of users

Author: hatifnatt

docker/defaults.yaml

@@ -39,8 +39,8 @@ docker:
 
       name: docker-ce
       service:
-        name: dockerd
-        env: null
+        name: docker
+        env: ''
       suffix: tgz
       commands:
         - docker

docker/files/default/systemd.ini.jinja

@@ -5,7 +5,7 @@
 Description={{ desc }}
 Wants=network-online.target
 After=
-Documentation=https://github.com/saltstack-formulas/prometheus-formula
+Documentation=https://docs.docker.com
 
 [Service]
 User={{ user }}

docker/software/archive/install.sls

@@ -94,7 +94,7 @@
         workdir: {{ d.dir.lib }}
         env: {{ d.pkg.docker.service.env }}
         stop: ''
-        start: {{ d.pkg.docker.path }}/{{ d.pkg.docker.service.name }}
+        start: {{ d.pkg.docker.path }}/dockerd
   cmd.run:
     - name: systemctl daemon-reload
     - require:

docker/software/service/running.sls

@@ -44,12 +44,13 @@ include:
         {%- endif %}
     - enable: True
         {%- if grains.kernel|lower == 'linux' %}
-    - onlyif: systemctl list-unit-files | grep {{ d.pkg.docker.service.name }} >/dev/null 2>&1
 
 {{ formula }}-software-service-running-docker-fail-notify:
-  test.show_notification:
-    - text: |
-        * Rebooting your host is recommended!
+  test.fail_without_changes:
+    - comment: |
+        Formula is trying to start '{{ d.pkg.docker.service.name }}' service
+        but failed, is it a correct name for Docker service in your OS?
+
         In certain circumstances the docker service will not start.
         Your kernel is missing some modules, or not in ideal state.
         See https://github.com/moby/moby/blob/master/contrib/check-config.sh

pillar.example

@@ -9,6 +9,7 @@ docker:
   pkg:
     docker:
       service:
+        name: docker
         env: HTTP_PROXY=http://YOUR_PROXY_IP_ADDRESS:PROXY_PORT
       environ:
         # yamllint disable-line rule:line-length