fix: results-dir does not require junit

Author: mshanemc

src/commands/project/deploy/start.ts

@@ -135,9 +135,9 @@ export default class DeployMetadata extends SfCommand<DeployResultJson> {
       options: reportsFormatters,
       helpValue: reportsFormatters.join(','),
     }),
-    junit: Flags.boolean({ summary: messages.getMessage('flags.junit') }),
+    junit: Flags.boolean({ summary: messages.getMessage('flags.junit'), dependsOn: ['coverage-formatters'] }),
     'results-dir': Flags.directory({
-      dependsOn: ['junit', 'coverage-formatters'],
+      dependsOn: ['coverage-formatters'],
       summary: messages.getMessage('flags.results-dir'),
     }),
   };

src/utils/output.ts

@@ -58,9 +58,7 @@ import {
 
 Messages.importMessagesDirectory(__dirname);
 const deployAsyncMessages = Messages.loadMessages('@salesforce/plugin-deploy-retrieve', 'deploy.async');
-
 const retrieveMessages = Messages.loadMessages('@salesforce/plugin-deploy-retrieve', 'retrieve.metadata');
-
 const convertMessages = Messages.loadMessages('@salesforce/plugin-deploy-retrieve', 'convert.source');
 
 function tableHeader(message: string): string {

test/nuts/seeds/deploy.metadata.test-level.seed.ts

@@ -112,17 +112,21 @@ context('deploy metadata --test-level NUTs [name: %REPO_NAME%]', () => {
       const packages = testkit.packageNames.map((p) => `--source-dir ${p}`).join(' ');
 
       execCmd(
-        `project:deploy:start ${packages} --test-level RunAllTestsInOrg  --coverage-formatters html --results-dir abc`
+        `project:deploy:start ${packages} --test-level RunAllTestsInOrg --coverage-formatters html --results-dir abc`,
+        { ensureExitCode: 0 }
       );
       expect(fs.existsSync(path.join(testkit.projectDir, 'abc', 'coverage', 'html', 'index.html'))).to.be.true;
       await testkit.expect.apexTestsToBeRun();
     });
 
     it('should run tests in org --coverage-formatters html and store in directory and contain junit', async () => {
-      const packages = testkit.packageNames.map((p) => `--source-dir ${p} --coverage-formatters html`).join(' ');
-      execCmd(`project:deploy:start ${packages} --test-level RunAllTestsInOrg --results-dir abc --junit`, {
-        ensureExitCode: 0,
-      });
+      const packages = testkit.packageNames.map((p) => `--source-dir ${p}`).join(' ');
+      execCmd(
+        `project:deploy:start ${packages} --test-level RunAllTestsInOrg  --coverage-formatters html --results-dir abc --junit`,
+        {
+          ensureExitCode: 0,
+        }
+      );
       await testkit.expect.apexTestsToBeRun();
       expect(fs.existsSync(path.join(testkit.projectDir, 'abc', 'coverage', 'html', 'index.html'))).to.be.true;
       expect(fs.existsSync(path.join(testkit.projectDir, 'abc', 'junit', 'junit.xml'))).to.be.true;