Add std_rng feature, remove deprecations #948
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test is now redundant with testing within the getrandom repository.
These feature flags are re-exports from getrandom and were already scheduled for removal in 0.8.
vks
approved these changes
Mar 9, 2020
bjorn3
reviewed
Mar 9, 2020
| - `getrandom` (implied by `std`) is an optional dependency providing the code | ||
| behind `rngs::OsRng` | ||
| - `std_rng` enables inclusion of `StdRng`, `thread_rng` and `random` | ||
| (the latter two *also* require that `std` be enabled) |
Contributor
There was a problem hiding this comment.
Maybe add std as requirement for std_rng in Cargo.toml?
Member
Author
There was a problem hiding this comment.
Why? Perhaps utility is limited, but this still passes:
$ cargo test --no-default-features --features std_rng --tests
...
test rngs::std::test::test_stdrng_construction ... ok
...
Collaborator
|
I think this is ready to be merged. |
This was referenced Mar 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #938 - CC @matklad.
As a side-effect,
stdon its own doesn't do that much —ReadRng, one use ofHashMap(vsBTreeMap), an implementation ofError.Also removes a lot of deprecated code.