Disentangle nightly and simd_support feature
#1048
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now `nightly` can be used without implying `simd_support`. This hopefully makes the `nightly` feature more stable and improves compilation time if `simd_support` is not required. The documentation and changelog were updated accordingly.
Collaborator
Author
|
This will also require an update to the Rand book. The CI does not check whether |
Collaborator
Author
|
It seems like |
dhardy
approved these changes
Sep 22, 2020
Member
dhardy
left a comment
dhardy
left a comment
There was a problem hiding this comment.
LGTM. Yes, ideally we should have at least one test of each independently. We could just use different flags on Travis and AppVeyor.
This was referenced Mar 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now
nightlycan be used without implyingsimd_support. Thishopefully makes the
nightlyfeature more stable and improvescompilation time if
simd_supportis not required.The documentation and changelog were updated accordingly.
Fixes #1047.