Skip to content

impl PartialEq, Eq for rngs #979

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 29, 2020
Merged

impl PartialEq, Eq for rngs #979

merged 1 commit into from
May 29, 2020

Conversation

@kazcw
Copy link
Contributor

@kazcw kazcw commented May 19, 2020 •
edited by dhardy
Loading

Implements #964. As in #975, but defining equality such that the user is
not exposed to the fact that one logical state may have different
representations in an implementation-specific way.

dhardy
dhardy reviewed May 20, 2020
View reviewed changes
Copy link
Member

@dhardy dhardy left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks correct, but we overlooked a bug in get_word_pos in your port of our ChaCha code 😬

Edit: I was wrong (see #980). Rebase please.

@rickvanprim rickvanprim mentioned this pull request May 22, 2020
Closed
@kazcw
impl PartialEq, Eq for rngs
f18f86d 
Implements rust-random#974. As in rust-random#975, but defining equality such that the user is
not exposed to the fact that one logical state may have different
representations in an implementation-specific way.
@kazcw
Copy link
Contributor Author

kazcw commented May 28, 2020 •
edited
Loading

@dhardy, Squashed and rebased.

@dhardy dhardy merged commit 4b99567 into rust-random:master May 29, 2020
@bjorn3 bjorn3 mentioned this pull request Aug 15, 2020
Closed
vks added a commit to vks/rand that referenced this pull request Aug 24, 2020
@vks
Fix chacha performance
ad2ea0a 
This reverts a change from rust-random#979 that introduced a massive performance
regression by disabling SIMD for `rand_chacha`.

Likely, the behavior of `ppv-lite86` should rather be fixed. This change
serves as a workaround until a fixed version is available.

Fixes rust-random#1017.
@vks vks mentioned this pull request Aug 24, 2020
Merged
vks added a commit that referenced this pull request Aug 28, 2020
@vks
Fix chacha performance
fbcfa22 
This reverts a change from #979 that introduced a massive performance
regression by disabling SIMD for `rand_chacha`.

Likely, the behavior of `ppv-lite86` should rather be fixed. This change
serves as a workaround until a fixed version is available.

Fixes #1017.
@CAD97 CAD97 mentioned this pull request Dec 21, 2020
Merged
@sync-by-unito sync-by-unito bot mentioned this pull request Dec 21, 2020
Closed
This was referenced Mar 9, 2021
Merged
Open
Open
@dependabot dependabot bot mentioned this pull request Mar 16, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dhardy dhardy dhardy approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kazcw @dhardy