Skip to content

Conversation

@josephlr
Copy link
Member

Per discussion in #889, we are keeping getrandom optional. Users can now specify custom RNG handlers for getrandom on any target. However, not all users will want OsRng, so getrandom needs to be optional.

Signed-off-by: Joe Richey [email protected]

Signed-off-by: Joe Richey <[email protected]>
@josephlr josephlr added this to the 0.8 release milestone Sep 10, 2020
@josephlr josephlr requested review from dhardy and vks and removed request for dhardy September 10, 2020 11:10
@dhardy
Copy link
Member

dhardy commented Sep 10, 2020

Thanks @josephlr.

The codes CUSTOM_START and INTERNAL_START can now be re-exported from getrandom I believe. But, see #984: we should probably document exactly what these values are and assert that they will never change.

@vks
Copy link
Collaborator

vks commented Sep 14, 2020

@dhardy I don't think we can re-export them as long as getrandom is an optional dependency. Instead, I documented the error codes as being identical to the ones in getrandom and added a test to make sure.

@josephlr
Copy link
Member Author

@dhardy I don't think we can re-export them as long as getrandom is an optional dependency. Instead, I documented the error codes as being identical to the ones in getrandom and added a test to make sure.

Thanks! I also updated the comments to link to the getrandom documentation.

Signed-off-by: Joe Richey <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants