FEAT: Also used OwnedRepr for ArcArray

Author: bluss

src/data_traits.rs

@@ -8,7 +8,6 @@
 
 //! The data (inner representation) traits for ndarray
 
-use crate::extension::nonnull::nonnull_from_vec_data;
 use rawpointer::PointerExt;
 use std::mem::{self, size_of};
 use std::ptr::NonNull;
@@ -188,7 +187,7 @@ unsafe impl<A> RawDataClone for RawViewRepr<*mut A> {
 unsafe impl<A> RawData for OwnedArcRepr<A> {
     type Elem = A;
     fn _data_slice(&self) -> Option<&[A]> {
-        Some(&self.0)
+        Some(self.0.as_slice())
     }
     private_impl! {}
 }
@@ -226,7 +225,7 @@ where
         };
         let rvec = Arc::make_mut(rcvec);
         unsafe {
-            self_.ptr = nonnull_from_vec_data(rvec).offset(our_off);
+            self_.ptr = rvec.as_nonnull_mut().offset(our_off);
         }
     }
 
@@ -242,7 +241,7 @@ unsafe impl<A> Data for OwnedArcRepr<A> {
         D: Dimension,
     {
         Self::ensure_unique(&mut self_);
-        let data = OwnedRepr::from(Arc::try_unwrap(self_.data.0).ok().unwrap());
+        let data = Arc::try_unwrap(self_.data.0).ok().unwrap();
         ArrayBase {
             data,
             ptr: self_.ptr,
@@ -416,13 +415,13 @@ unsafe impl<A> DataOwned for OwnedRepr<A> {
         OwnedRepr::from(elements)
     }
     fn into_shared(self) -> OwnedRcRepr<A> {
-        OwnedArcRepr(Arc::new(self.into_vec()))
+        OwnedArcRepr(Arc::new(self))
     }
 }
 
 unsafe impl<A> DataOwned for OwnedArcRepr<A> {
     fn new(elements: Vec<A>) -> Self {
-        OwnedArcRepr(Arc::new(elements))
+        OwnedArcRepr(Arc::new(OwnedRepr::from(elements)))
     }
 
     fn into_shared(self) -> OwnedRcRepr<A> {

src/lib.rs

@@ -1402,7 +1402,7 @@ pub use self::OwnedArcRepr as OwnedRcRepr;
 /// *Don’t use this type directly—use the type alias
 /// [`ArcArray`](type.ArcArray.html) for the array type!*
 #[derive(Debug)]
-pub struct OwnedArcRepr<A>(Arc<Vec<A>>);
+pub struct OwnedArcRepr<A>(Arc<OwnedRepr<A>>);
 
 impl<A> Clone for OwnedArcRepr<A> {
     fn clone(&self) -> Self {